Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single layer image processing improvements #8276

Merged
merged 16 commits into from
Jan 20, 2024

Conversation

Districh-ru
Copy link
Collaborator

This PR is a part of #8241 but without changes to transform() layer memory allocation and reset() of transform layer.

@Districh-ru Districh-ru added the improvement New feature, request or improvement label Jan 14, 2024
@Districh-ru Districh-ru added this to the 1.0.12 milestone Jan 14, 2024
@Districh-ru Districh-ru requested a review from ihhub January 14, 2024 08:17
@Districh-ru Districh-ru self-assigned this Jan 14, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/2)

src/engine/image.cpp Show resolved Hide resolved
src/engine/image.cpp Show resolved Hide resolved
src/engine/image.cpp Show resolved Hide resolved
src/engine/image.cpp Show resolved Hide resolved
src/engine/image.cpp Show resolved Hide resolved
src/engine/image.cpp Show resolved Hide resolved
src/engine/image.cpp Show resolved Hide resolved
src/engine/image.cpp Show resolved Hide resolved
src/engine/image.cpp Show resolved Hide resolved
src/engine/image.cpp Show resolved Hide resolved
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (2/2)

src/engine/zzlib.cpp Show resolved Hide resolved
Copy link
Owner

@ihhub ihhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Districh-ru , I put 2 comments here. Would you mind to take a look at them when you have time?

src/engine/image.cpp Show resolved Hide resolved
src/engine/screen.cpp Show resolved Hide resolved
@ihhub ihhub merged commit f603255 into ihhub:master Jan 20, 2024
21 checks passed
@ihhub
Copy link
Owner

ihhub commented Jan 20, 2024

@Districh-ru , thank you so much for these improvements!

ihhub added a commit that referenced this pull request Jan 20, 2024
@Districh-ru Districh-ru deleted the single-layer-image-improvements branch January 20, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature, request or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants