-
-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dialog to choose between Auto Resolve and Auto Combat #9180
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
…to auto-resolve
use drawOnState, exit dialog only upon action change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
Hi, @zenseii ! Nice work! This dialog definitely makes gameplay more comfortable.
What if we take the other window type and make this dialog look like the existing adventure/file options? I mean we can use that brown marble window type with the same buttons and texts you've implemented. I noticed one text issue with descriptions but not sure it is relevant though: And the AUTO COMBAT description states: Were the first words chosen to be different on purpose? |
This will let more users notice the Auto Resolve feature and it will give touch devices access to Auto Resolve.
Related to #9094