Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dialog to choose between Auto Resolve and Auto Combat #9180

Draft
wants to merge 24 commits into
base: master
Choose a base branch
from

Conversation

zenseii
Copy link
Collaborator

@zenseii zenseii commented Oct 10, 2024

This will let more users notice the Auto Resolve feature and it will give touch devices access to Auto Resolve.

image

Related to #9094

@zenseii zenseii added improvement New feature, request or improvement ui UI/GUI related stuff labels Oct 10, 2024
@zenseii zenseii added this to the 1.1.4 milestone Oct 10, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

src/fheroes2/battle/battle_interface.cpp Outdated Show resolved Hide resolved
src/fheroes2/battle/battle_interface.cpp Outdated Show resolved Hide resolved
@ihhub ihhub modified the milestones: 1.1.4, 1.1.5 Nov 27, 2024
@ihhub ihhub modified the milestones: 1.1.5, 1.1.6 Dec 30, 2024
@zenseii zenseii changed the title Add dialog to choose between auto-resolve and auto-combat Add dialog to choose between Auto Resolve and Auto Combat Jan 3, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

src/fheroes2/battle/battle_interface.cpp Outdated Show resolved Hide resolved
src/fheroes2/battle/battle_interface.cpp Outdated Show resolved Hide resolved
@Branikolog
Copy link
Collaborator

Hi, @zenseii !

Nice work! This dialog definitely makes gameplay more comfortable.
From interaction point this dialog is absolutely fine!
Here are my few notes on the implementation and the design.

  • I suppose, large button is considered as a prototype yet? I feel there are some shiny areas missing on them:
    image

  • I feel two rows of buttons are rarely used in the game UI. In my personal opinion, the placement of three buttons so close to each other in two rows alongside looks a little out of place here. The large buttons increase this feeling even further. :) I can hardly mention any similar dialog with the same kind of design.

What if we take the other window type and make this dialog look like the existing adventure/file options?
image

I mean we can use that brown marble window type with the same buttons and texts you've implemented.

I noticed one text issue with descriptions but not sure it is relevant though:
Right click on the "AUTO" button states:
image

And the AUTO COMBAT description states:
image

Were the first words chosen to be different on purpose?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature, request or improvement ui UI/GUI related stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants