Set the PROJECT_VERSION for PSV in XX.YY format #9423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-derevenetz
added
bug
|
Hi, @oleg-derevenetz, this PR works good on emulator: I've asked Pønytail to test this build on his hardware. |
As far as I understand, on emulator everything works fine even without this PR? :) |
Yes, the emulator reads the version string and displays it (as a string) when installing and then in the applications list: The real hardware, I think, does some version analysis which needs |
ihhub
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #9418 (comment)
Still can not detect some type of errors - e.g. the absence of
version.txtitself (will set the version to 00.00 in this case), because GNU Make runs the shell inshmode, which doesn't support thebashextensions - e.g. the-o pipefailoption, but it's still better than no error handling at all.