-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SVO logging #598
base: develop
Are you sure you want to change the base?
SVO logging #598
Conversation
@@ -180,7 +185,8 @@ protected int openCamera() | |||
@Override | |||
public boolean isSensorRunning() | |||
{ | |||
return sl_is_opened(cameraID) && !lastGrabFailed; | |||
boolean recentlyGrabbed = lastGrabTime != null && lastGrabTime.isAfter(Instant.now().minusSeconds(1)); | |||
return sl_is_opened(cameraID) && !lastGrabFailed && recentlyGrabbed; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -109,6 +112,8 @@ protected boolean startSensor() | |||
sl_enable_positional_tracking(cameraID, positionalTrackingParameters, ""); | |||
} | |||
|
|||
sl_enable_streaming(cameraID, SL_STREAMING_CODEC_H264, 8000, (short) streamingPort, -1, 0, 16084, CAMERA_FPS); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean it's always streaming, even when doing local tests & development?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Streaming is always enabled, not necessarily streaming to anything
@@ -109,6 +112,8 @@ protected boolean startSensor() | |||
sl_enable_positional_tracking(cameraID, positionalTrackingParameters, ""); | |||
} | |||
|
|||
sl_enable_streaming(cameraID, SL_STREAMING_CODEC_H264, 8000, (short) streamingPort, -1, 0, 16084, CAMERA_FPS); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could use StreamingTools.getOpenPort()
here. Though it's kinda nice knowing that ZED uses port 30000 and up. Up to you to decide which method you prefer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to keep it like this, since ZED SDK typically always uses port 30000 or around there
I imagine we'll add the sensor pose into the ZED Stream in the future? Or should that happen in this PR? |
Future change |
No description provided.