Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVO logging #598

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

SVO logging #598

wants to merge 7 commits into from

Conversation

ds58
Copy link
Contributor

@ds58 ds58 commented Jan 13, 2025

No description provided.

@ds58 ds58 changed the title [WIP] SVO logging SVO logging Jan 14, 2025
@ds58 ds58 marked this pull request as ready for review January 14, 2025 17:17
@@ -180,7 +185,8 @@ protected int openCamera()
@Override
public boolean isSensorRunning()
{
return sl_is_opened(cameraID) && !lastGrabFailed;
boolean recentlyGrabbed = lastGrabTime != null && lastGrabTime.isAfter(Instant.now().minusSeconds(1));
return sl_is_opened(cameraID) && !lastGrabFailed && recentlyGrabbed;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -109,6 +112,8 @@ protected boolean startSensor()
sl_enable_positional_tracking(cameraID, positionalTrackingParameters, "");
}

sl_enable_streaming(cameraID, SL_STREAMING_CODEC_H264, 8000, (short) streamingPort, -1, 0, 16084, CAMERA_FPS);
Copy link
Member

@calvertdw calvertdw Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean it's always streaming, even when doing local tests & development?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Streaming is always enabled, not necessarily streaming to anything

@@ -109,6 +112,8 @@ protected boolean startSensor()
sl_enable_positional_tracking(cameraID, positionalTrackingParameters, "");
}

sl_enable_streaming(cameraID, SL_STREAMING_CODEC_H264, 8000, (short) streamingPort, -1, 0, 16084, CAMERA_FPS);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use StreamingTools.getOpenPort() here. Though it's kinda nice knowing that ZED uses port 30000 and up. Up to you to decide which method you prefer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to keep it like this, since ZED SDK typically always uses port 30000 or around there

@TomaszTB
Copy link
Contributor

I imagine we'll add the sensor pose into the ZED Stream in the future? Or should that happen in this PR?

@ds58
Copy link
Contributor Author

ds58 commented Jan 15, 2025

I imagine we'll add the sensor pose into the ZED Stream in the future? Or should that happen in this PR?

Future change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants