Fix bug retrieving depth buffer for mouse scene collision #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvertdw
commented
Jan 28, 2025
| @@ -129,9 +129,9 @@ public Point3DReadOnly getPickPointInWorld(double fallbackXYPlaneIntersectionHei | |||
|
|
|||
| int rowAdjustment = aliasedFlippedMouseY * aliasedRenderedAreaWidth * Float.BYTES; | |||
| int columnAdjustment = aliasedMouseX * Float.BYTES; | |||
| float normalizedDeviceCoordinateZ = depthBuffer.getFloat(rowAdjustment + columnAdjustment); | |||
| float normalizedDeviceCoordinateZ = 2.0f * depthBuffer.getFloat(rowAdjustment + columnAdjustment) - 1.0f; | |||
There was a problem hiding this comment.
Apply the same math that's in the depth sensor shader
calvertdw
commented
Jan 28, 2025
| GL41.glPixelStorei(GL41.GL_UNPACK_ALIGNMENT, 4); // to read floats | ||
| // Note: This line has significant performance impact | ||
| GL41.glReadPixels(0, 0, (int) renderSizeX, (int) renderSizeY, GL41.GL_RED, GL41.GL_FLOAT, normalizedDeviceCoordinateDepthDirectByteBuffer); | ||
| GL41.glReadPixels(0, 0, (int) renderSizeX, (int) renderSizeY, GL41.GL_DEPTH_COMPONENT, GL41.GL_FLOAT, normalizedDeviceCoordinateDepthDirectByteBuffer); |
There was a problem hiding this comment.
Switch to correctly using the DEPTH_COMPONENT
calvertdw
commented
Jan 28, 2025
| @@ -65,4 +65,20 @@ public static void clear(HeightMapMessage messageToClear) | |||
| messageToClear.getVariances().clear(); | |||
| messageToClear.getCentroids().clear(); | |||
| } | |||
|
|
|||
| public static void setToFlatGround(HeightMapMessage message) | |||
There was a problem hiding this comment.
Useful for generating a flat ground height map graphic for testing purposes.
calvertdw
commented
Jan 28, 2025
There was a problem hiding this comment.
This demo class has been expanded to cover more cases for mouse scene collision.
TomaszTB
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depth for scene collision looked like this for some objects because we retrieved the RED channel erroneously. Now that we moved to the GLTF shader by msgX, it's actually the red channel. Easily fixed by doing the correct thing and grabbing the depth attachment.
After the fix:
