Prevent setting to null values when there are no changes to undo, whi… #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvertdw
commented
Feb 4, 2025
| notes.setValue(onDiskNotes); | ||
| if (isUndoAvailable()) | ||
| { | ||
| name.setValue(onDiskName); |
There was a problem hiding this comment.
The primary crash was name getting set to null, which native crashed an ImGui function.
LuigiPenco93
approved these changes
Feb 4, 2025
calvertdw
force-pushed
the
bugfix/undo-crash
branch
from
9f444f4 to
decd4d8
Compare
calvertdw
force-pushed
the
bugfix/undo-crash
branch
from
decd4d8 to
88ecfa5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ch caused crash.