Add bar chart to IHME-UI #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbeame
requested review from
evanl5,
davschne,
jimvermillion,
Ryshackleton and
komalali
kbeame
changed the title
Ryshackleton
suggested changes
Sep 14, 2018
There was a problem hiding this comment.
This looks really good Kat, and I'm excited to try this out in some projects! Thanks for making the effort to get this done.
Most of my comments are re formatting and documentation, but there are a few that relate to things now showing up (legends in the demos) and one typo that could cause problems. Let me know if you have any questions. Good work!
komalali
suggested changes
Sep 17, 2018
Ryshackleton
approved these changes
Sep 17, 2018
komalali
approved these changes
Sep 19, 2018
Codecov Report
@@ Coverage Diff @@
## master #171 +/- ##
==========================================
- Coverage 89.17% 86.73% -2.45%
==========================================
Files 74 93 +19
Lines 2107 2615 +508
Branches 405 510 +105
==========================================
+ Hits 1879 2268 +389
- Misses 225 342 +117
- Partials 3 5 +2
Continue to review full report at Codecov.
|
davschne
suggested changes
Sep 26, 2018
davschne
force-pushed
the
make-one-barchart-to-rule-them-all
branch
from
6170173 to
e314877
Compare
|
I've refactored the bar-chart components in this PR. The biggest changes are:
|
davschne
approved these changes
Feb 26, 2019
davschne
force-pushed
the
make-one-barchart-to-rule-them-all
branch
from
393f8fd to
94b792f
Compare
added 25 commits
March 14, 2019 12:40
It's a default export, not a named export.
The build:all script was removing output directories, but the individual build scripts ('commonjs', 'es', 'umd') did not.
There's no 'legend-wrapper' class defined in the corresponding style.css, so I can't see a purpose for this div.
This will allow navigation in code editors. It should preserve the existing functionality on GitHub.
There's no need to form a separate data structure for the legend items. We can just use the subcategory names, then supply accessors to translate these names to the appropriate values.
Putting a ResponsiveContainer inside this component is problematic. If a consumer of the component doesn't apply styles correctly, either to the containing element or via style props, the component is likely to render with height and/or width of 0, making the chart invisible. The revised interface requires specifying the chart dimensions (with defaults applied if not specified). While this approach offers a bit less flexibility, I think it makes the sizing easier to understand and consumption of the component far less error-prone.
- Adding Bao Dinh - Adding everyone's GitHub profile URLs
davschne
force-pushed
the
make-one-barchart-to-rule-them-all
branch
from
3426e6f to
4383d68
Compare
added 2 commits
March 14, 2019 13:03
- "preversion" now begins with "npm install." Since we're bundling some dependencies in the UMD build, we want to make sure the packages actually installed in node_modules are up to date with the specified dependencies in package.json and package-lock.json. - "postversion" now explicitly specifies the URL of the GitHub repo. This should make the script work even if some assumptions (like having a Git remote set up or having a local branch tracking the remote "master") aren't satisfied.
react-dom is not actually a runtime dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for the large pull request.
This pull-request includes the all of the work that Bao did last summer and my updates based on Gabe and Aaron's initial comments on Bao's work. It also includes the update to React 16 necessary to bring it up to date. It also includes my more recent work to make a composition component that is more flexible than how Bao had his set up.
'Stacked' can be anything from a regular bar-chart to a grouped multi bar-chart to a stacked multi bar-chart. Ideally this one component will be able to handle most options one might need, it just depends on how the data is structured.