move data deps to core #397
Open
+3
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patricktnast
requested review from
albrja,
collijk,
hussain-jafari,
rmudambi and
stevebachmeier
as code owners
albrja
approved these changes
Jan 29, 2025
albrja
reviewed
Jan 29, 2025
| @@ -24,12 +24,12 @@ | |||
| "vivarium>=1.2.1", | |||
| "gbd_mapping>=4.0.0, <5.0.0", | |||
| "loguru", | |||
| "vivarium-gbd-access>=4.1.0, <5.0.0", | |||
There was a problem hiding this comment.
Won't this break when we try to release it on pypi?
There was a problem hiding this comment.
that's a good point, we want to just stop making vivarium inputs a pypi package (and use artifactory instead), but you're correct in pointing out that that blocks this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title: Summary, imperative, start upper case, don't end with a period
Description
Changes and notes
Summary. If/when we move automated builds off of github-actions and to jenkins, we can then move
vivarium_gbd_accessandcore-mathsfrom thedatasetup requirements and into the core ones.Testing
this should fail github actions and pass jenkins