Ensure conflict resolution is fine for ssp-dev
rebase
#297
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, @OFR-IIASA reported that we need a minimum version for sdmx1. We already have such a requirement on
main
, but didn't rebasessp-dev
after #295 was merged.Upon rebasing
ssp-dev
onmain
, I ran into this merge conflict:This likely arose because some type hints were adjusted on
main
such that git recognized some part of this line and thought it was just changed when in reality, the one onmain
was replaced entirely. I kept the version onssp-dev
, which ended up being changed again by later commits, anyway, AFAICT.The PR also adjust a commit message that was oddly formatted.
How to review
For everyone except @khaeru: you're notified as a code owner, but this PR doesn't include any new changes that are not already on
ssp-dev
(except for two type hint fixes).For @khaeru:
PR checklist