Add Docker support and image CI #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmcguire81
reviewed
Nov 14, 2022
| RUN sed -i 's:\.\./:/meta/:g' config.toml | ||
|
|
||
| WORKDIR /meta/build | ||
| RUN cmake .. -DCMAKE_BUILD_TYPE=Release -DBUILD_SHARED_LIBS=On -DBUILD_STATIC_ICU=On -DLIBCXX_LIBRARY=/lib/llvm-14/lib/libc++.so.1 |
dmcguire81
approved these changes
Nov 14, 2022
| @@ -0,0 +1,38 @@ | |||
| name: Docker Image CI | |||
There was a problem hiding this comment.
Looks great. I think we have a lot of options for wrapping this up.
There was a problem hiding this comment.
Thank you. After the initial release is ready, we can limit this action to run only on the master branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Dockerfile and a GitHub Workflow/Action to build and publish it to DockerHub. The container has the following features:
arm64andamd64. The ARM support is important because docker emulation foramd64is slow, and one of the main issues reported in our cohort was getting MeTA to work on M1 chips.config.toml. So, tasks like profiling or PoS tagging just require the user to set up theconfig.tomland run the container./usr/local/liband/usr/local/include, so users can reference it in their C++ applications.