Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Make non-strict mode faster for classes. Addresses #1071 #1107

Merged
merged 4 commits into from
Apr 27, 2024
Merged

feat: Make non-strict mode faster for classes. Addresses #1071 #1107

merged 4 commits into from
Apr 27, 2024

Conversation

mweststrate
Copy link
Collaborator

@mweststrate mweststrate commented Mar 11, 2024 •
edited
Loading

  • [x]: fix tests. Maybe introduce additional flag as this might be dangerous for classes.
  • [x]: can we optimize each / finalize based on the same setting? See Faster iteration experiment #1120
  • [x]: make a tristate flag? !strict is very unsafe for classes

@mweststrate mweststrate mentioned this pull request Mar 11, 2024
Closed
@coveralls
Copy link

coveralls commented Mar 11, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8862180750

Details

  • 21 of 21 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 99.794%
Totals Coverage Status
Change from base Build 8861675542: 0.001%
Covered Lines: 649
Relevant Lines: 650
💛 - Coveralls

@mweststrate mweststrate merged commit 53e3203 into main Apr 27, 2024
2 checks passed
@github-actions GitHub Actions
Copy link
Contributor

🎉 This PR is included in version 10.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mweststrate mweststrate mentioned this pull request Apr 27, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mweststrate @coveralls