Initial suite of samples #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the teapot character, demonstrating the API as discussed so far.
zachernuk
requested review from
Yonet,
AdaRoseCannon,
cabanier and
LaszloGombos
|
@mkeblx These are the samples I mentioned! |
mkeblx
suggested changes
May 2, 2025
autoplay-loop.html
Outdated
| </p> | ||
|
|
||
| <pre> | ||
| <model autoplay alt="A model of a teapot with a hidden creature"> |
There was a problem hiding this comment.
No loop attribute present here in code sample
autorotate.html
Outdated
|
|
||
| <h2>HTML</h2> | ||
| <pre> | ||
| <model id="model" alt="A model of a teapot"> |
There was a problem hiding this comment.
For these code sections I believe want to also excape the > chars.
| </body> | ||
| <script type="module"> | ||
| let initialTransform; | ||
| await model.ready; |
There was a problem hiding this comment.
Some samples like here use the more ~legacy fact that HTML element with ID x shows up window.x, while others do not. Can we always explicitly reference the element via a selector?
basic-data-url.html
Outdated
| const model = document.querySelector('model'); | ||
| const {src, type} = model.dataset; | ||
| const bytes = await (await fetch(src)).bytes(); | ||
| const srcString = URL.createObjectURL(new Blob([bytes], {type})); |
There was a problem hiding this comment.
This is actually a blob URL test case, as using createObjectURL => blob.
Blob URL:
const response = await fetch(url);
const blob = await response.blob(); // this should maintain type too
const objectURL = URL.createObjectURL(blob);We should probably have two demo pages, one for data URL, and blob URL.
~data URL:
const response = await fetch(url);
const blob = await response.blob();
const reader = new FileReader();
reader.readAsDataURL(blob);
currenttime.html
Outdated
| </body> | ||
|
|
||
| <script> | ||
| (async () => { |
There was a problem hiding this comment.
Like other samples, can we use script type="module" which has top level await and remove this async wrapper?
jsorbit.html
Outdated
| <meta charset="UTF-8" /> | ||
| <meta http-equiv="X-UA-Compatible" content="IE=edge" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>Model: Orbit test</title> |
playbackrate.html
Outdated
| <meta charset="UTF-8" /> | ||
| <meta http-equiv="X-UA-Compatible" content="IE=edge" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>Model: basic test</title> |
currenttime.html
Outdated
| <meta charset="UTF-8" /> | ||
| <meta http-equiv="X-UA-Compatible" content="IE=edge" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>Model: basic test</title> |
boundingbox.html
Outdated
| <meta charset="UTF-8" /> | ||
| <meta http-equiv="X-UA-Compatible" content="IE=edge" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>Model: basic test</title> |
background.html
Outdated
Replaced the `>` characters in the `pre` sections with the escaped character, Made use of type="module" script tags and omitted the script tags in their respective `pre` sections, Added and updated the titles, Renamed the DataURL test to accurately reflect that it's a Blob URL test, Made sure there is a valid query selector rather than relying on the global-namespaced references by ID.
|
@mkeblx Thank you so much for catching all that! Take a look again when you can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the teapot character, demonstrating the API as discussed so far!