Fix: use the date timestamp with the proper timezone on the donor dashboard #7671
+23
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glaubersilva
changed the title
glaubersilva
changed the title
|
|
||
| return $date->getTimestamp(); | ||
| } catch (Exception $e) { | ||
| return 0; |
There was a problem hiding this comment.
Hey what happens if there is an error? Should we add a log or maybe a fallback timestamp?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves GIVE-1233
Description
This PR changes how we pass the date to the
human_time_diff()function. Instead of using thestrtotime()function, we are now using the newTemporal::getDateTimestamp()method that automatically uses the proper timezone to generate the timestamp.Affects
The donor dashboard.
Visuals
Testing Instructions
Last donated {TIME} agoandDonor for {TIME}.Pre-review Checklist
@unreleasedtags included in DocBlocks