Refactor: check if the form goal is enabled before calling the goal stats function in the GetAsyncFormDataForListView class #7676
+12
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| private function isFormGoalEnabled(int $formId): bool | ||
| { | ||
| return give_is_setting_enabled(Give()->form_meta->get_meta($formId, | ||
| DonationFormMetaKeys::GOAL_OPTION()->getKeyAsCamelCase(), true)); |
There was a problem hiding this comment.
Since this meta is v2 backwards compatible, we may also want to optionally check for the v3 flag specifically:
$donationForm->settings->enableDonationGoal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves GIVE-2085
Description
This PR changes how the async approach to load form data in the form list table works. Now, instead of calling the
give_goal_progress_stats()for all forms, it calls only for the forms that have the goal option enabled.Affects
The "All Forms" list table
Testing Instructions
This code is not directly responsible for the "Division by zero" error related to this other PR, but the changes implemented here can indirectly fix the same problem.
So, to test these changes, you can use the develop branch of the Fee Recovery add-on and follow the same test instructions from this PR: https://github.com/impress-org/give-fee-recovery/pull/341
Pre-review Checklist
@unreleasedtags included in DocBlocks