api/reddit: add support for resolving short links in comments #950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zjy4fun
reviewed
Dec 19, 2024
KwiatekMiki
reviewed
Dec 26, 2024
| let url; | ||
|
|
||
| if (obj.shortLink) { | ||
| const resolvedUrl = await resolveShortLink(obj.shortLink); |
There was a problem hiding this comment.
Suggested change
| const resolvedUrl = await resolveShortLink(obj.shortLink); | |
| const resolvedUrl = await getRedirectingURL(obj.shortLink); |
Comment on lines
51
to
53
| async function resolveShortLink(url) { | ||
| return await getRedirectingURL(url); | ||
| } |
There was a problem hiding this comment.
Suggested change
| async function resolveShortLink(url) { | |
| return await getRedirectingURL(url); | |
| } |
apply suggestions
|
i tried downloading the link from the mentioned issue (#910), but i am getting: |
|
replaced by #1197 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new function to resolve short links (fixes #910) and integrates it into the existing Reddit comment fetching logic. The most significant changes include adding a new helper function and modifying the main export function to handle short links.
Enhancements to URL resolution:
api/src/processing/services/reddit.js: Added theresolveShortLinkfunction to handle the resolution of short links using aHEADrequest and manual redirection.Improvements to main function:
api/src/processing/services/reddit.js: Modified the default export function to check for a short link and use the newresolveShortLinkfunction. If a short link is provided and cannot be resolved, it returns an error. Otherwise, it constructs the URL based on the subreddit or user comment path.