Skip to content

Commit

Permalink
Remove outdated TODO as the issue is fixed (#271)
Browse files Browse the repository at this point in the history
  • Loading branch information
longquanzheng authored Nov 23, 2024
1 parent 6add8aa commit b2994f1
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions src/main/java/io/iworkflow/core/StateDecision.java
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,6 @@ public static <I> StateDecision forceCompleteIfInternalChannelEmptyOrElse(final
* Atomically force complete the workflow if internal channel is empty, otherwise trigger the state movements from the current thread
* This is important for use case that needs to ensure all the messages in the channel are processed before completing the workflow, otherwise messages will be lost.
* Without this atomic API, if user just check the channel emptiness in the State APIs, the channel may receive new messages during the execution of state APIs
* <br>
* Note that today this doesn't cover the case that internal messages are published from other State APIs yet. It's only for internal messages published from RPCs.
* If you do want to use other State APIs to publish messages to the channel at the same time, you can use persistence locking to ensure only the State APIs are not executed
* in parallel. See more in TODO https://github.com/indeedeng/iwf/issues/289
*
* @param completionOutput the output of workflow completion
* @param internalChannelName the internal channel name for checking emptiness
Expand Down

0 comments on commit b2994f1

Please sign in to comment.