Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove broken and unused methods and return parameters for waitForStateExecutionCompletion #245

Merged
merged 4 commits into from
Oct 4, 2024

Conversation

longquanzheng
Copy link
Contributor

@longquanzheng longquanzheng commented Oct 4, 2024

Description

See also indeedeng/iwf#439

Checklist

  • Code compiles correctly
  • Tests for the changes have been added
  • All tests passing

Related Issue

Closes #<issue_number>

README.md Outdated
Comment on lines 156 to 158
### 2.6

- [x] Add waitForStateExecutionCompletion API
- [x] Small breaking changes to IdReusePolicy for fixing typo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to remove the 2.5 section?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops! Fixed.

@longquanzheng longquanzheng merged commit b8e8510 into main Oct 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants