Resolves ENGA-932 "Modify BigQueryExporter class export() method to accept a pull_date" #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENGA-932
Non-technical Context
For the sake of backfilling or coordinating a pull date across multiple models, we want the export function to accept a pull_date argument
Technical Context
I added the pull_date parameter which defaults to None. The pull_time used internally by the method is then set to either the specified pull_date, or now if no pull_date is set.
As an aside, I added .order_by('id') to the default queryset method to accommodate the batching of querysets where ordering avoids reprocessing or missing records.
Developer
Reviewer