Fix rubocop offenses

indydevs · Feb 3, 2024 · 981e957 · 981e957
1 parent 9a063b5
commit 981e957
Show file tree

Hide file tree

Showing 7 changed files with 18 additions and 12 deletions.
diff --git a/Rakefile b/Rakefile
@@ -46,7 +46,7 @@ end
 
 desc "Get release notes for the current or specific version"
 task :release_notes, [:version] do |_t, args|
-  version = (args[:version] || Flutter::VERSION)
+  version = args[:version] || Flutter::VERSION
   parser = Keepachangelog::MarkdownParser.load("CHANGELOG.md")
   parser.parsed_content.delete("intro")
   parser.parsed_content.delete("title")

diff --git a/lib/flutter/minitest.rb b/lib/flutter/minitest.rb
@@ -5,7 +5,7 @@
 
 begin
   require "minitest"
-rescue LoadError  # rubocop:disable Lint/SuppressedException
+rescue LoadError # rubocop:disable Lint/SuppressedException
 end
 
 module Flutter
@@ -15,8 +15,10 @@ class << self
 
       def flutter_tracker
         @tracker ||= Flutter::Tracker.new(
-          Flutter.config.sources, Flutter.config.exclusions,
-          Flutter.config.storage_class, Flutter.config.storage_options
+          Flutter.config.sources,
+          Flutter.config.exclusions,
+          Flutter.config.storage_class,
+          Flutter.config.storage_options,
         )
       end
     end

diff --git a/lib/flutter/persistence.rb b/lib/flutter/persistence.rb
@@ -96,7 +96,7 @@ def initialize(path:)
       # (see AbstractStorage#load!)
       def load!
         if File.exist?(@full_path)
-          persisted = YAML.load(File.read(@full_path), **YAML_LOAD_OPTS)
+          persisted = YAML.load_file(@full_path, **YAML_LOAD_OPTS)
           @state.update(persisted) if persisted
         end
       end

diff --git a/lib/flutter/rspec.rb b/lib/flutter/rspec.rb
@@ -10,8 +10,10 @@ class << self
 
       def tracker
         @tracker ||= Flutter::Tracker.new(
-          Flutter.config.sources, Flutter.config.exclusions,
-          Flutter.config.storage_class, Flutter.config.storage_options
+          Flutter.config.sources,
+          Flutter.config.exclusions,
+          Flutter.config.storage_class,
+          Flutter.config.storage_options,
         )
       end
     end
@@ -55,8 +57,10 @@ class << self
     config.around(:each) do |example|
       Flutter::RSpec.tracker.start(example.full_description) if Flutter.enabled
       example.run
-      Flutter::RSpec.tracker.stop(example.full_description,
-        example.execution_result.exception.nil?) if Flutter.enabled
+      Flutter::RSpec.tracker.stop(
+        example.full_description,
+        example.execution_result.exception.nil?,
+      ) if Flutter.enabled
     end
 
     config.after(:suite) do

diff --git a/lib/flutter/tracker.rb b/lib/flutter/tracker.rb
@@ -79,7 +79,7 @@ def skip?(test, test_location, test_source)
       test_source_unchanged = @test_source_mapping[test_location_rel][test] == @source_mapping.dig(
         test_location_rel, test
       )
-      return unless test_seen && test_source_unchanged
+      return false unless test_seen && test_source_unchanged
 
       sources = @test_mapping[test] || {}
       sources.map do |file, methods|

diff --git a/test/test_flutter.rb b/test/test_flutter.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_relative "./test_helper"
+require_relative "test_helper"
 
 class TestFlutter < Minitest::Test
   def test_that_it_has_a_version_number

diff --git a/test/test_tracker.rb b/test/test_tracker.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_relative "./test_helper"
+require_relative "test_helper"
 require "flutter/tracker"
 require "flutter/persistence"