Skip to content

Support configuration via env #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@ AllCops:
TargetRubyVersion: 3.0
NewCops: enable
SuggestExtensions: false
Exclude:
- 'node_modules/**/*'
- 'tmp/**/*'
- 'vendor/**/*'
- '.git/**/*'
- 'docs/**/*'

Metrics:
Enabled: false
Expand Down
106 changes: 27 additions & 79 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
@@ -1,19 +1,11 @@
# This configuration was generated by
# `rubocop --auto-gen-config --exclude-limit 10000`
# on 2024-11-22 18:44:50 UTC using RuboCop version 1.68.0.
# on 2025-03-01 10:06:34 UTC using RuboCop version 1.73.1.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.

# Offense count: 1
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle, IndentationWidth.
# SupportedStyles: outdent, indent
Layout/AccessModifierIndentation:
Exclude:
- 'lib/inertia_rails/configuration.rb'

# Offense count: 2
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle, IndentationWidth.
Expand All @@ -23,7 +15,7 @@ Layout/ArgumentAlignment:
- 'bin/console'
- 'spec/inertia/response_spec.rb'

# Offense count: 5
# Offense count: 9
# This cop supports safe autocorrection (--autocorrect).
Layout/BlockEndNewline:
Exclude:
Expand All @@ -37,18 +29,10 @@ Layout/CaseIndentation:
Exclude:
- 'lib/inertia_rails/renderer.rb'

# Offense count: 2
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: AllowForAlignment.
Layout/CommentIndentation:
Exclude:
- 'lib/inertia_rails/rspec.rb'

# Offense count: 2
# Offense count: 1
# This cop supports safe autocorrection (--autocorrect).
Layout/EmptyLineAfterGuardClause:
Exclude:
- 'lib/inertia_rails/configuration.rb'
- 'lib/inertia_rails/controller.rb'

# Offense count: 1
Expand Down Expand Up @@ -97,14 +81,7 @@ Layout/FirstArgumentIndentation:
Layout/FirstHashElementIndentation:
EnforcedStyle: consistent

# Offense count: 1
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: Width, AllowedPatterns.
Layout/IndentationWidth:
Exclude:
- 'spec/inertia/configuration_spec.rb'

# Offense count: 5
# Offense count: 9
# This cop supports safe autocorrection (--autocorrect).
Layout/MultilineBlockLayout:
Exclude:
Expand All @@ -118,7 +95,7 @@ Layout/MultilineMethodCallIndentation:
Exclude:
- 'spec/inertia/ssr_spec.rb'

# Offense count: 7
# Offense count: 6
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces.
# SupportedStyles: space, no_space
Expand All @@ -139,19 +116,18 @@ Layout/SpaceInsideArrayLiteralBrackets:
- 'spec/dummy/app/controllers/inertia_test_controller.rb'
- 'spec/dummy/config/environments/production.rb'

# Offense count: 20
# Offense count: 13
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
# SupportedStyles: space, no_space
# SupportedStylesForEmptyBraces: space, no_space
Layout/SpaceInsideBlockBraces:
Exclude:
- 'spec/inertia/configuration_spec.rb'
- 'spec/inertia/error_sharing_spec.rb'
- 'spec/inertia/rendering_spec.rb'
- 'spec/inertia/request_spec.rb'

# Offense count: 128
# Offense count: 122
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces.
# SupportedStyles: space, no_space, compact
Expand All @@ -163,7 +139,6 @@ Layout/SpaceInsideHashLiteralBraces:
- 'spec/dummy/app/controllers/inertia_conditional_sharing_controller.rb'
- 'spec/dummy/app/controllers/inertia_share_test_controller.rb'
- 'spec/inertia/conditional_sharing_spec.rb'
- 'spec/inertia/configuration_spec.rb'
- 'spec/inertia/middleware_spec.rb'
- 'spec/inertia/rails_mimic_spec.rb'
- 'spec/inertia/rendering_spec.rb'
Expand All @@ -181,7 +156,7 @@ Layout/TrailingEmptyLines:
- 'lib/tasks/inertia_rails.rake'
- 'spec/inertia/rails_mimic_spec.rb'

# Offense count: 12
# Offense count: 10
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: AllowInHeredoc.
Layout/TrailingWhitespace:
Expand Down Expand Up @@ -226,7 +201,8 @@ Lint/UnderscorePrefixedVariableName:

# Offense count: 1
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: AutoCorrect, AllowUnusedKeywordArguments, IgnoreEmptyMethods, IgnoreNotImplementedMethods.
# Configuration parameters: AutoCorrect, AllowUnusedKeywordArguments, IgnoreEmptyMethods, IgnoreNotImplementedMethods, NotImplementedExceptions.
# NotImplementedExceptions: NotImplementedError
Lint/UnusedMethodArgument:
Exclude:
- 'lib/patches/mapper.rb'
Expand Down Expand Up @@ -254,7 +230,7 @@ Naming/VariableNumber:
Exclude:
- 'spec/dummy/app/controllers/inertia_test_controller.rb'

# Offense count: 21
# Offense count: 25
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle, ProceduralMethods, FunctionalMethods, AllowedMethods, AllowedPatterns, AllowBracesOnProceduralOneLiners, BracesRequiredMethods.
# SupportedStyles: line_count_based, semantic, braces_for_chaining, always_braces
Expand All @@ -263,11 +239,9 @@ Naming/VariableNumber:
# AllowedMethods: lambda, proc, it
Style/BlockDelimiters:
Exclude:
- 'lib/inertia_rails/configuration.rb'
- 'lib/inertia_rails/controller.rb'
- 'spec/inertia/action_filter_spec.rb'
- 'spec/inertia/conditional_sharing_spec.rb'
- 'spec/inertia/configuration_spec.rb'
- 'spec/inertia/rendering_spec.rb'
- 'spec/inertia/request_spec.rb'
- 'spec/inertia/rspec_helper_spec.rb'
Expand Down Expand Up @@ -331,20 +305,20 @@ Style/ExpandPathArguments:
Exclude:
- 'spec/rails_helper.rb'

# Offense count: 74
# Offense count: 71
# This cop supports unsafe autocorrection (--autocorrect-all).
# Configuration parameters: EnforcedStyle.
# SupportedStyles: always, always_true, never
Style/FrozenStringLiteralComment:
Exclude:
- '**/*.arb'
- 'app/controllers/inertia_rails/static_controller.rb'
- 'bin/console'
- 'lib/inertia_rails.rb'
- 'lib/inertia_rails/controller.rb'
- 'lib/inertia_rails/engine.rb'
- 'lib/inertia_rails/helper.rb'
- 'lib/inertia_rails/inertia_rails.rb'
- 'lib/inertia_rails/middleware.rb'
- 'lib/inertia_rails/rspec.rb'
- 'lib/inertia_rails/version.rb'
- 'lib/patches/better_errors.rb'
Expand Down Expand Up @@ -396,7 +370,6 @@ Style/FrozenStringLiteralComment:
- 'spec/inertia/always_prop_spec.rb'
- 'spec/inertia/base_prop_spec.rb'
- 'spec/inertia/conditional_sharing_spec.rb'
- 'spec/inertia/configuration_spec.rb'
- 'spec/inertia/error_sharing_spec.rb'
- 'spec/inertia/lazy_prop_spec.rb'
- 'spec/inertia/middleware_spec.rb'
Expand All @@ -409,7 +382,6 @@ Style/FrozenStringLiteralComment:
- 'spec/inertia/ssr_spec.rb'
- 'spec/rails_helper.rb'
- 'spec/spec_helper.rb'
- 'spec/support/helper_module.rb'
- 'spec/support/shared_examples.rb'

# Offense count: 1
Expand All @@ -424,13 +396,6 @@ Style/GlobalVars:
Exclude:
- 'spec/inertia/rspec_helper_spec.rb'

# Offense count: 1
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: MinBodyLength, AllowConsecutiveConditionals.
Style/GuardClause:
Exclude:
- 'lib/inertia_rails/configuration.rb'

# Offense count: 1
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle, EnforcedShorthandSyntax, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols.
Expand All @@ -440,11 +405,10 @@ Style/HashSyntax:
Exclude:
- 'lib/tasks/inertia_rails.rake'

# Offense count: 6
# Offense count: 5
# This cop supports safe autocorrection (--autocorrect).
Style/IfUnlessModifier:
Exclude:
- 'lib/inertia_rails/configuration.rb'
- 'lib/inertia_rails/controller.rb'
- 'lib/patches/better_errors.rb'
- 'lib/patches/debug_exceptions/patch-5-0.rb'
Expand All @@ -457,12 +421,6 @@ Style/IfUnlessModifierOfIfUnless:
Exclude:
- 'lib/inertia_rails/controller.rb'

# Offense count: 1
# This cop supports safe autocorrection (--autocorrect).
Style/KeywordArgumentsMerging:
Exclude:
- 'lib/inertia_rails/configuration.rb'

# Offense count: 3
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle.
Expand All @@ -479,12 +437,6 @@ Style/MapToSet:
Exclude:
- 'lib/inertia_rails/action_filter.rb'

# Offense count: 1
# This cop supports safe autocorrection (--autocorrect).
Style/MultilineIfModifier:
Exclude:
- 'lib/inertia_rails/configuration.rb'

# Offense count: 1
# This cop supports unsafe autocorrection (--autocorrect-all).
# Configuration parameters: EnforcedStyle.
Expand All @@ -493,7 +445,7 @@ Style/MutableConstant:
Exclude:
- 'lib/inertia_rails/version.rb'

# Offense count: 1
# Offense count: 2
# This cop supports safe autocorrection (--autocorrect).
Style/NegatedIfElseCondition:
Exclude:
Expand Down Expand Up @@ -558,7 +510,7 @@ Style/SoleNestedConditional:
Exclude:
- 'lib/inertia_rails/controller.rb'

# Offense count: 90
# Offense count: 82
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
# SupportedStyles: single_quotes, double_quotes
Expand All @@ -580,15 +532,12 @@ Style/StringLiterals:
- 'spec/dummy/app/controllers/inertia_config_test_controller.rb'
- 'spec/dummy/app/controllers/inertia_lambda_shared_props_controller.rb'
- 'spec/dummy/app/controllers/inertia_rails_mimic_controller.rb'
- 'spec/dummy/app/controllers/inertia_render_test_controller.rb'
- 'spec/dummy/config/application.rb'
- 'spec/dummy/config/environments/production.rb'
- 'spec/dummy/config/puma.rb'
- 'spec/dummy/config/routes.rb'
- 'spec/dummy/config/spring.rb'
- 'spec/inertia/conditional_sharing_spec.rb'
- 'spec/inertia/configuration_spec.rb'
- 'spec/inertia/rendering_spec.rb'
- 'spec/inertia/response_spec.rb'
- 'spec/inertia/rspec_helper_spec.rb'
- 'spec/rails_helper.rb'
Expand All @@ -610,23 +559,21 @@ Style/SymbolArray:
EnforcedStyle: percent
MinSize: 3

# Offense count: 16
# Offense count: 14
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyleForMultiline.
# SupportedStylesForMultiline: comma, consistent_comma, no_comma
Style/TrailingCommaInArguments:
Exclude:
- 'lib/inertia_rails.rb'
- 'lib/inertia_rails/renderer.rb'
- 'spec/dummy/app/controllers/inertia_config_test_controller.rb'
- 'spec/dummy/app/controllers/inertia_rails_mimic_controller.rb'
- 'spec/inertia/configuration_spec.rb'
- 'spec/inertia/rendering_spec.rb'

# Offense count: 21
# Offense count: 22
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyleForMultiline.
# SupportedStylesForMultiline: comma, consistent_comma, no_comma
# SupportedStylesForMultiline: comma, consistent_comma, diff_comma, no_comma
Style/TrailingCommaInHashLiteral:
Exclude:
- 'lib/inertia_rails/rspec.rb'
Expand All @@ -639,17 +586,18 @@ Style/TrailingCommaInHashLiteral:
- 'spec/inertia/response_spec.rb'
- 'spec/inertia/rspec_helper_spec.rb'

# Offense count: 1
# Offense count: 2
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: WordRegex.
# Configuration parameters: EnforcedStyle, MinSize, WordRegex.
# SupportedStyles: percent, brackets
Style/WordArray:
EnforcedStyle: percent
MinSize: 4
Exclude:
- 'lib/inertia_rails/middleware.rb'
- 'spec/inertia/rendering_spec.rb'

# Offense count: 21
# Offense count: 26
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns.
# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns, SplitStrings.
# URISchemes: http, https
Layout/LineLength:
Max: 290
Max: 276
Loading