fix uirating using only default setting prop value #546
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonya0504
approved these changes
Mar 21, 2025
AlanLes
reviewed
Mar 21, 2025
Comment on lines
+238
to
+242
| icon: props.settings.iconActive, | ||
| ...radioOptionAttrs?.iconActiveAttrs, | ||
| }, | ||
| iconDefaultAttrs: { | ||
| icon: defaultProps.value.settings.iconDefault, | ||
| icon: props.settings.iconDefault, |
There was a problem hiding this comment.
IMO this should stay as it is, and the actual fix should be on lines 203-206:
settings: {
iconDefault,
iconActive,
},
should be changed to:
settings: ...props.settings,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
UiRating wont use the provided settings prop
Related Issue
Closes #
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Checklist: