Feature/open source template #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZvonimirMedak
added
documentation
nikolamajcen
approved these changes
Nov 20, 2024
| @@ -28,7 +30,7 @@ This library supports both **Swift** and **Objective-C**. | |||
|
|
|||
| ## Requirements | |||
|
|
|||
| * iOS 10 and above | |||
| * iOS 11 and above | |||
| * Xcode 10 and above | |||
There was a problem hiding this comment.
I'm not sure if this would work on Xcode 10.
| UserDefaultsTool(), | ||
| CustomLocationTool() | ||
| ], | ||
| preferences: optionSwitchItems |
There was a problem hiding this comment.
Please add optionSwitchItems somewhere because it is hard to understand what they are in this example.
| e.g. The app supports Analitycs and you can add an `OptionSwitchTool` which will be shown on the `Preferences` screen and the user can turn it off if he doesn't want it. | ||
|
|
||
| ```swift | ||
| OptionSwitchItem( |
There was a problem hiding this comment.
Remove indentation for this example.
| @@ -0,0 +1 @@ | |||
| * @nikolamajcen @ZvonimirMedak | |||
There was a problem hiding this comment.
Honestly, I'm totally fine that you set only yourself here as a maintainer. I could be added manually any time you need me 👍
| ) | ||
|
|
||
| Sentinel.shared.setup(with: configuration) | ||
| let configuration = Sentinel.Configuration( |
Comment on lines
7
to
10
| [](https://app.bitrise.io/app/56dc4082e9c3bb9e) | ||
| [](https://cocoapods.org/pods/Sentinel) | ||
| [](https://cocoapods.org/pods/Sentinel) | ||
| [](https://cocoapods.org/pods/Sentinel#license) | ||
| [](https://cocoapods.org/pods/Sentinel) |
There was a problem hiding this comment.
For the better appearance, you can center this if you want :)
| #### Swift Package Manager | ||
|
|
||
| If you are using SPM for your dependency manager, add this to the dependencies in your `Package.swift` file: | ||
|
|
||
| ```swift | ||
| dependencies: [ | ||
| .package(url: "https://github.com/infinum/ios-sentinel.git") | ||
| .package(url: "https://github.com/infinum/ios-sentinel.git") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I have updated the repository to be closer in line with the new open-source-template
Changes
Type
Additional information
Description
Checklist
Additional notes
The rest of the updates will be done through other pull requests