-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Iceberg Integration documentation #5918
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this looks good. My suggestions are mostly for following our style and "tightening up". We should add examples where noted ASAP, but it shouldn't necessarily hold up publishing when the feature is ready.
Co-authored-by: Jason Stirnaman <[email protected]>
Co-authored-by: Jason Stirnaman <[email protected]>
Co-authored-by: Jason Stirnaman <[email protected]>
Co-authored-by: Jason Stirnaman <[email protected]>
Co-authored-by: Jason Stirnaman <[email protected]>
Co-authored-by: Jason Stirnaman <[email protected]>
Co-authored-by: Jason Stirnaman <[email protected]>
Co-authored-by: Jason Stirnaman <[email protected]>
Co-authored-by: Jason Stirnaman <[email protected]>
Co-authored-by: Jason Stirnaman <[email protected]>
Thank you for the suggestions and help! I should probably go slower and triple check that I am using the Google developers documentation style guide. @jstirnaman |
Co-authored-by: Jason Stirnaman <[email protected]>
Co-authored-by: Jason Stirnaman <[email protected]>
Co-authored-by: Jason Stirnaman <[email protected]>
Co-authored-by: Jason Stirnaman <[email protected]>
Co-authored-by: Jason Stirnaman <[email protected]>
Co-authored-by: Jason Stirnaman <[email protected]>
Co-authored-by: Jason Stirnaman <[email protected]>
Co-authored-by: Jason Stirnaman <[email protected]>
Co-authored-by: Jason Stirnaman <[email protected]>
Ideally, Vale should be catching violations as well, but I think we're missing some config for the newer directories.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more minor suggestions
Co-authored-by: Jason Stirnaman <[email protected]>
Co-authored-by: Jason Stirnaman <[email protected]>
#### Example: Enable Iceberg feature and export a snapshot | ||
|
||
```sh | ||
# Enable Iceberg feature | ||
$ influxctl enable-iceberg | ||
|
||
# Export a snapshot | ||
$ influxctl export --namespace foo --table bar | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commands should be used in the process above, not influxdb_iox
### Use the API to manage and configure snapshots | ||
|
||
Use the {{% product-name %}} HTTP API to export snapshots and check status. | ||
|
||
#### Example: Export a snapshot | ||
|
||
This example demonstrates how to export a snapshot of your data from InfluxDB to an Iceberg table using the HTTP API. | ||
|
||
- **Method**: `POST` | ||
- **Endpoint**: `/snapshots/export` | ||
- **Request body**: | ||
|
||
```json | ||
{ | ||
"namespace": "foo", | ||
"table": "bar" | ||
} | ||
``` | ||
The `POST` request to the `/snapshots/export` endpoint triggers the export of data from the specified namespace and table in InfluxDB to an Iceberg table. The request body specifies the namespace (`foo`) and the table (`bar`) to be exported. | ||
|
||
#### Example: Check snapshot status | ||
|
||
This example shows how to check the status of an ongoing or completed snapshot export using the HTTP API. | ||
|
||
- **Method**: `GET` | ||
- **Endpoint**: `/snapshots/status` | ||
|
||
The `GET` request to the `/snapshots/status` endpoint retrieves the status of the snapshot export. This can be used to monitor the progress of the export or verify its completion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should use tabs above and explain how to do each of these via CLI and API in the actual process flow rather than down at the bottom.
Co-authored-by: Scott Anderson <[email protected]>
Co-authored-by: Scott Anderson <[email protected]>
Co-authored-by: Scott Anderson <[email protected]>
Co-authored-by: Scott Anderson <[email protected]>
Co-authored-by: Scott Anderson <[email protected]>
Co-authored-by: Scott Anderson <[email protected]>
Co-authored-by: Scott Anderson <[email protected]>
Co-authored-by: Scott Anderson <[email protected]>
Co-authored-by: Scott Anderson <[email protected]>
Co-authored-by: Scott Anderson <[email protected]>
Co-authored-by: Scott Anderson <[email protected]>
Co-authored-by: Scott Anderson <[email protected]>
Co-authored-by: Scott Anderson <[email protected]>
Adding documentation for Iceberg Integration with Snowflake.