feat: Add SetNewReadersBlocked for purger.purge #26114
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm wanting to add a test that has contention between filestore.Apply and filestore.Replace where there are multiple TSM files being Ref'ed and Unref'ed while attempting to run them through the purger. I'm struggling to be able to write proper test cases for this.
gwossum
reviewed
Mar 10, 2025
tsdb/engine/tsm1/file_store_test.go
Outdated
Comment on lines
3051
to
3052
| dir := MustTempDir() | ||
| defer os.RemoveAll(dir) |
There was a problem hiding this comment.
Could you use t.TempDir() instead?
gwossum
reviewed
Mar 10, 2025
tsdb/engine/tsm1/file_store_test.go
Outdated
Comment on lines
3073
to
3078
| fs.Apply(func(r tsm1.TSMFile) error { | ||
| overlapsTimeRangeMinMaxLock.Lock() | ||
| time.Sleep(time.Duration(rand.Intn(5)) * time.Millisecond) | ||
| overlapsTimeRangeMinMaxLock.Unlock() | ||
| return nil | ||
| }) |
There was a problem hiding this comment.
The use of fs.Apply to inject mischief is really smart. However, the overlapsTimeRangeMinMaxLock just makes the goroutines launched by fs.Apply run in a serial manner, equivalent to having the limiter in fs.Apply only allow 1 goroutine at a time. Given that, I'm not the mutex helps create contention more than just doing time.Sleep.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP