Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p2p: replace x25519-dalek with curve25519-dalek-ng #1370

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

tony-iqlusion
Copy link
Collaborator

The tendermint-p2p crate previously pulled in both an obsolete version of x25519-dalek/curve25519-dalek, but also curve25519-dalek-ng by way of ed25519-consensus.

This replaces x25519-dalek with curve25519-dalek-ng which is already a dependency of ed25519-consensus. This reduces the overall number of dependencies and ensures curve25519-dalek-ng is the main Curve25519 implementation used.

Note: I don't have an open issue for this but since it reduces the overall number of dependencies I thought it made sense.

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

The `tendermint-p2p` crate previously pulled in both an obsolete version
of `x25519-dalek`/`curve25519-dalek`, but also `curve25519-dalek-ng` by
way of `ed25519-consensus`.

This replaces `x25519-dalek` with `curve25519-dalek-ng` which is already
a dependency of `ed25519-consensus`. This reduces the overall number of
dependencies and ensures `curve25519-dalek-ng` is the main Curve25519
implementation used.
@tony-iqlusion tony-iqlusion force-pushed the replace-x25519-dalek-with-curve25519-dalek-ng branch from 8477382 to 7da8183 Compare October 11, 2023 16:25
@codecov-commenter
Copy link

Codecov Report

Merging #1370 (e91b0b4) into main (bcc0b37) will not change coverage.
The diff coverage is 87.5%.

❗ Current head e91b0b4 differs from pull request most recent head 7da8183. Consider uploading reports for the commit 7da8183 to get more accurate results

@@          Coverage Diff          @@
##            main   #1370   +/-   ##
=====================================
  Coverage   61.2%   61.2%           
=====================================
  Files        274     274           
  Lines      26844   26844           
=====================================
  Hits       16433   16433           
  Misses     10411   10411           
Files Coverage Δ
p2p/src/secret_connection.rs 85.5% <100.0%> (ø)
test/src/test/unit/p2p/secret_connection.rs 100.0% <100.0%> (ø)
p2p/src/secret_connection/protocol.rs 59.8% <50.0%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@romac romac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@romac romac merged commit 2c4f096 into main Oct 13, 2023
25 checks passed
@romac romac deleted the replace-x25519-dalek-with-curve25519-dalek-ng branch October 13, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants