p2p: replace x25519-dalek
with curve25519-dalek-ng
#1370
Merged
+19
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
tendermint-p2p
crate previously pulled in both an obsolete version ofx25519-dalek
/curve25519-dalek
, but alsocurve25519-dalek-ng
by way ofed25519-consensus
.This replaces
x25519-dalek
withcurve25519-dalek-ng
which is already a dependency ofed25519-consensus
. This reduces the overall number of dependencies and ensurescurve25519-dalek-ng
is the main Curve25519 implementation used.Note: I don't have an open issue for this but since it reduces the overall number of dependencies I thought it made sense.
.changelog/