timeout instead of race to fix async wait time
#222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arybczak
added a commit
to scrive/hedis
that referenced
this pull request
Apr 25, 2025
The former works reliably, whether the latter doesn't. Case in point: ``` uninterruptibleMask_ $ race (putStrLn "Hi") (threadDelay 1000000) ``` will wait a second even though the first operation finishes immediately. See informatikr#222 - I couldn't reproduce this behaviour locally, but we might be also hitting this problem for some reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement: In an application deployed in my organisation, we were seeing an increased time to connect to redis, when we increased the value of
connectTimeout.Reason: This was happening because of the higher timeout value which was being passed to
raceinconnectfunction astimeoutOpt. Functionraceinternally callscanceland cancel will not terminate until the thread that Async refers to has been terminated.Solution : Used timeout function instead of
raceto handle that scenario and now it works fine.