-
Notifications
You must be signed in to change notification settings - Fork 131
Updated commands.json to the version of 200160226 #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
85f9feb
to
e6a9fdb
Compare
Perhaps it could be wise to write in the same time the unit tests for everything? That way when the big change comes (I understand @informatikr wanted to go for a full handwritten API instead of generated code), we can go more smoothly? |
@Thooms this would be highly appreciated. On my side, I started checking this PR against my work-project to make sure at least basic stuff works on tests/staging (maybe even prod for load-testing, but we'll see). |
OK, I'm on it then. I'll try to write as much unittests as I can, let's see afterwards for the rest! |
that sounds good @Thooms - do you want to put those unittests into this PR? |
@qrilka I would prefer starting a new branch (since we're not only talking about updating the API anymore), and cherry-picking your commit into it, if you're okay with that. |
Sure, other option is to merge this one and unittests as another PR and not do any releases until we have good coverage. |
I think cherry-picking should provide a good way to have these PRs separately implemented, but once Thooms's is ready, I can merge this one and Thooms's then, should work well. |
Hello there, just a small message to signal I'm still working on the testsuite. There a lot of code to write, and I can't commit for now, but I'll make a PR as soon as it's showable :) |
-> #61 |
e6a9fdb
to
d0dd9f2
Compare
Will do, no problem! |
I've merged this branch into commands-20160226 branch in the main hedis repo, thank you! Let's continue working on top of that one everyone. |
As it's a quite a heavy patch I think we'll need to review it thoroughly
Also I see what could be improved (some commands could easily be fully supported e.g.)
And for sure we'll need a major version bump for this.