fix: properly calculate deadline, use chrono for calculating timestamps
#123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Evalir
force-pushed
the
evalir/builder-debug-stuff
branch
from
51d4c66 to
7613bf1
Compare
prestwich
reviewed
Jul 2, 2025
Evalir
changed the title
chrono for calculating timestamps
prestwich
force-pushed
the
evalir/builder-debug-stuff
branch
from
fa955fe to
9da0142
Compare
Evalir
commented
Jul 4, 2025
| .send_transaction(req) | ||
| .instrument(span.clone()) | ||
| .await | ||
| .inspect_err(|e| error!(error = %e, "sending transaction")) |
There was a problem hiding this comment.
this was probably written this way because it's implied with the error i assume, but i still think it can be confusing at first glance
Suggested change
| .inspect_err(|e| error!(error = %e, "sending transaction")) | |
| .inspect_err(|e| error!(error = %e, "error sending transaction")) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were calculating the deadline by subtracting from an
Instant::now(), which we shouldn't do. We now simply subtract the buffer from the remaining time in the slot and add the result to the current instant instead.This also switches to using
chronofor anything regarding timestamps instead of usingstd, for parity with the slot calculator. Everything else usesInstantorDurationalready.Closes ENG-1167
Closes ENG-1019