feat: JournalDb trait #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Evalir
reviewed
Aug 13, 2025
| /// and state. | ||
| /// | ||
| /// This is intended to be used for tx simulation, and other purposes that | ||
| /// need fast state access WITHTOUT needing to retrieve historical data. |
There was a problem hiding this comment.
Suggested change
| /// need fast state access WITHTOUT needing to retrieve historical data. | |
| /// need fast state access WITHOUT needing to retrieve historical data. |
| let journal_hash = update.journal_hash(); | ||
|
|
||
| // TODO: remove the clone in future versions. This can be achieved by | ||
| // _NOT_ making a `BlockResult` and instead manually updating relevan |
There was a problem hiding this comment.
Suggested change
| // _NOT_ making a `BlockResult` and instead manually updating relevan | |
| // _NOT_ making a `BlockResult` and instead manually updating relevant |
|
|
||
| // TODO: remove the clone in future versions. This can be achieved by | ||
| // _NOT_ making a `BlockResult` and instead manually updating relevan | ||
| // tables. However, this means diverging more fro the underlying reth |
There was a problem hiding this comment.
Suggested change
| // tables. However, this means diverging more fro the underlying reth | |
| // tables. However, this means diverging more from the underlying reth |
Evalir
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new extension trait
JournalDbthat can ingest trevm block updates into the journal