Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save and pull stack on entrypoints #531

Open
jpwilliams opened this issue Mar 27, 2024 · 1 comment
Open

Save and pull stack on entrypoints #531

jpwilliams opened this issue Mar 27, 2024 · 1 comment
Assignees
Labels
⬆️ improvement Performance, reliability, or usability improvements 📦 inngest Affects the `inngest` package

Comments

@jpwilliams
Copy link
Member

Summary

When the library emits a log to try and help the user diagnose or resolve an issue, we usually include a stack trace in order to provide them with a location to start the investigation.

More often than not, however, this stack trace is loaded with internal calls, flowing in and out of async, or other calls in the user's application.

image

On every entrypoint via userland code, we should store a stack trace ahead of time, such that any logs emitted to users via prettyError() can be attributed to those traces instead of our internal ones.

@jpwilliams jpwilliams added ⬆️ improvement Performance, reliability, or usability improvements 📦 inngest Affects the `inngest` package labels Mar 27, 2024
@jpwilliams jpwilliams self-assigned this Mar 27, 2024
Copy link

linear bot commented Mar 27, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⬆️ improvement Performance, reliability, or usability improvements 📦 inngest Affects the `inngest` package
Projects
None yet
Development

No branches or pull requests

1 participant