Add step name or ID when there’s a NESTING_STEPS error #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c984869 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Signed-off-by: Makara Sok <[email protected]>
|
This is great, @maktouch! Thanks for the contribution. In terms of the original issue (#546) and not being able to see which step is causing the problem, would #531 also be a part of helping with this? Basically, is the current stack trace useless as it's mostly listing calls internal to this library? |
jpwilliams
added
⬆️ improvement
|
Ideally, I think better stack traces are the way to go, so #531 makes sense. This is how it currently looks
|
Merged
jpwilliams
pushed a commit
that referenced
this pull request
Apr 23, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## [email protected] ### Patch Changes - [#520](#520) [`0703740`](0703740) Thanks [@jpwilliams](https://github.com/jpwilliams)! - Add selective header forwarding when sending events, allowing context propagation when tracing fanouts 👀 - [#549](#549) [`f759de1`](f759de1) Thanks [@maktouch](https://github.com/maktouch)! - Add step name or ID when there’s a NESTING_STEPS error Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When there's a NESTING_STEPS error, debugging it is tricky because the stack traces can't necessarily determine the correct faulty file.
Checklist
- [ ] Added a docs PR that references this PRN/A, this is augmenting an existing error- [ ] Added unit/integration testsN/A, I don't think it's worth it- [ ] Added changesets if applicableN/A, I don't think it's worth it.Related