Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix @inngest/test automatic spying not accounting for step.** #777

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

jpwilliams
Copy link
Member

@jpwilliams jpwilliams commented Dec 11, 2024

Summary

@inngest/test performs automatic mocking of the functions within the step object. This change ensure we also recursively apply those mocks such that step.**() is mocked, such as step.ai.infer().

Checklist

  • Added a docs PR that references this PR N/A Bug fix
  • Added unit/integration tests N/A Using in another PR
  • Added changesets if applicable

@jpwilliams jpwilliams added the Bug Something isn't working label Dec 11, 2024
@jpwilliams jpwilliams self-assigned this Dec 11, 2024
Copy link

changeset-bot bot commented Dec 11, 2024

🦋 Changeset detected

Latest commit: 87dec90

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@inngest/test Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jpwilliams jpwilliams added the prerelease/test Create snapshot releases for a PR for the "@inngest/test" package. label Dec 11, 2024
@inngest-release-bot
Copy link
Collaborator

A user has added the prerelease/test label, so this PR will be published to npm with the tag pr-777. It will be updated with the latest changes as you push commits to this PR.

You can install this prerelease version with:

npm install @inngest/test@pr-777

The last release was built and published from 87dec90.

@jpwilliams jpwilliams enabled auto-merge (squash) December 11, 2024 17:39
@jpwilliams jpwilliams merged commit 325ef79 into main Dec 11, 2024
63 checks passed
@jpwilliams jpwilliams deleted the fix/test-spy-mocks branch December 11, 2024 17:44
jpwilliams pushed a commit that referenced this pull request Dec 11, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @inngest/[email protected]

### Patch Changes

- [#777](#777)
[`325ef79`](325ef79)
Thanks [@jpwilliams](https://github.com/jpwilliams)! - Fix
`@inngest/test` automatic spying not accounting for `step.**`

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working 📦 @inngest/test prerelease/test Create snapshot releases for a PR for the "@inngest/test" package.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants