fix: optional Tooltip props [LW-12407] #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mchappell
approved these changes
Mar 5, 2025
mkazlauskas
reviewed
Mar 5, 2025
There was a problem hiding this comment.
tsc is happy without this for me in latest phase0, please check before merging, maybe this is not necessary https://github.com/input-output-hk/lace-platform/pull/331/commits/768402361cf72337b53c45b7ed7627fde7638c09
Feel free to merge without my approval if you find that this is required
mkazlauskas
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes too strict types for
Tooltipdue to usingPickwhich loses the optional quality for picked props.