Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add rules #24

Merged
merged 15 commits into from
Oct 29, 2024
Merged

Feature/add rules #24

merged 15 commits into from
Oct 29, 2024

Conversation

EddeCCC
Copy link
Member

@EddeCCC EddeCCC commented Oct 18, 2024

Use rule configuration with scopes and tracing actions

levinkerschberger
levinkerschberger requested changes Oct 24, 2024
View reviewed changes
Copy link
Member

@levinkerschberger levinkerschberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job!

Let´s go through my comments. Maybe you can explain some stuff to me, where I had questions.
I had to focus on code quality and robustness, cause functionallity-wise I´m a little off-board.

...agent/src/main/java/rocks/inspectit/gepard/agent/instrumentation/hook/MethodHookManager.java Outdated Show resolved Hide resolved
...d-agent/src/main/java/rocks/inspectit/gepard/agent/instrumentation/hook/MethodHookState.java Outdated Show resolved Hide resolved
...d-agent/src/main/java/rocks/inspectit/gepard/agent/instrumentation/hook/MethodHookState.java Outdated Show resolved Hide resolved
...d-agent/src/main/java/rocks/inspectit/gepard/agent/instrumentation/hook/MethodHookState.java Outdated Show resolved Hide resolved
...rocks/inspectit/gepard/agent/instrumentation/hook/configuration/MethodHookConfiguration.java Outdated Show resolved Hide resolved
...inspectit/gepard/agent/internal/instrumentation/model/rules/scopes/InstrumentationScope.java Show resolved Hide resolved
...inspectit/gepard/agent/internal/instrumentation/model/rules/scopes/InstrumentationScope.java Show resolved Hide resolved
...inspectit/gepard/agent/internal/instrumentation/model/rules/scopes/InstrumentationScope.java Show resolved Hide resolved
...inspectit/gepard/agent/internal/instrumentation/model/rules/scopes/InstrumentationScope.java Show resolved Hide resolved
...s/inspectit/gepard/agent/internal/instrumentation/rules/scopes/InstrumentationScopeTest.java Show resolved Hide resolved
levinkerschberger
levinkerschberger requested changes Oct 28, 2024
View reviewed changes
Copy link
Member

@levinkerschberger levinkerschberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really like the distinction between ClassHookConfiguration and MethodHookConfiguration!

...epard/agent/instrumentation/hook/configuration/resolver/MethodHookConfigurationResolver.java Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@EddeCCC EddeCCC merged commit c58d6ea into master Oct 29, 2024
8 checks passed
@EddeCCC EddeCCC deleted the feature/add-rules branch November 4, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levinkerschberger levinkerschberger levinkerschberger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EddeCCC @levinkerschberger