feat: include agent info into polling #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EddeCCC
requested changes
Nov 18, 2024
.../src/main/java/rocks/inspectit/gepard/agent/configuration/http/HttpConfigurationFactory.java
Outdated
Show resolved
Hide resolved
.../src/main/java/rocks/inspectit/gepard/agent/configuration/http/HttpConfigurationFactory.java
Outdated
Show resolved
Hide resolved
...src/main/java/rocks/inspectit/gepard/agent/configuration/http/HttpConfigurationCallback.java
Outdated
Show resolved
Hide resolved
|
EddeCCC
approved these changes
Nov 19, 2024
|
|
||
| headers.forEach(requestBuilder::addHeader); | ||
| agent | ||
| .getAttributes() | ||
| .forEach((key, value) -> requestBuilder.addHeader("X-Gepard-Attribute-" + key, value)); | ||
| .forEach((key, value) -> requestBuilder.addHeader(X_GEPARD_ATTRIBUTE + key, value)); |
There was a problem hiding this comment.
Hi @EddeCCC, @binarycoded,
Quick note: I changed the headers to lower-case, since the apache http client automatically lowercases them, when sending.
According to the http-specs, header names are case-insensitive (https://stackoverflow.com/questions/5258977/are-http-headers-case-sensitive). That might be the reason.
Long Story Short: On the the other side (config-server) you still need to check for lower-cased headers.
Was pretty painful to find that out while debugging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.