Skip to content

deps: Bump minimum required Python version to 3.11 #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

courtneypacheco
Copy link
Contributor

@courtneypacheco courtneypacheco commented May 15, 2025

Overview

In our core repo, we require Python >=3.11: https://github.com/instructlab/instructlab/blob/main/pyproject.toml#L13

In this repo, however, we currently require Python >=3.9, and we are only testing against Python 3.10 and 3.11 in the CI. Therefore, we should ensure consistency in terms of Python version support throughout our GitHub org.

Proposed Changes

This bump includes updates to documentation, Git workflows, test configs, etc.

This bump includes updates to documentation, Git workflows, test configs, etc.

Signed-off-by: Courtney Pacheco <[email protected]>
@mergify mergify bot added CI/CD Affects CI/CD configuration documentation Improvements or additions to documentation testing Relates to testing labels May 15, 2025
@@ -45,7 +45,6 @@ jobs:
fail-fast: false
matrix:
python:
- "3.10"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: We ultimately want to add Python 3.12 support, which is why I want to leave the matrix logic as is despite us only testing with 3.11 right now.

@courtneypacheco courtneypacheco marked this pull request as ready for review May 15, 2025 11:58
@courtneypacheco courtneypacheco requested review from RobotSail and a team May 15, 2025 11:59
@mergify mergify bot added the one-approval label May 15, 2025
@mergify mergify bot added the ci-failure label May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Affects CI/CD configuration ci-failure documentation Improvements or additions to documentation one-approval testing Relates to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants