Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated scope of pytest fixture to be function based #1131

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

ivanleomk
Copy link
Collaborator

@ivanleomk ivanleomk commented Oct 29, 2024

Important

Changed client fixture scope in conftest.py from session to function for per-test instantiation.

  • Testing:
    • Changed scope of client fixture in conftest.py from session to function to ensure fixture is instantiated per test function.

This description was created by Ellipsis for f11b053. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to f11b053 in 10 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. tests/llm/test_openai/conftest.py:16
  • Draft comment:
    Consider adding a docstring to the client fixture to describe its purpose and usage. This will improve code readability and maintainability.
  • Reason this comment was not posted:
    Confidence changes required: 33%
    The change from session to function scope for the pytest fixture is appropriate given the context of the code. However, the code can be improved for readability and maintainability.
2. tests/llm/test_openai/conftest.py:18
  • Draft comment:
    Assertions should always have an error message. Consider adding an error message to the assertion on line 18.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The code is mostly fine, but the assertion lacks an error message.

Workflow ID: wflow_poOHkddKXKZo5Kfc


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

Deploying instructor-py with  Cloudflare Pages  Cloudflare Pages

Latest commit: f11b053
Status: ✅  Deploy successful!
Preview URL: https://e3b9b349.instructor-py.pages.dev
Branch Preview URL: https://fix-oai-invalid-body.instructor-py.pages.dev

View logs

@ivanleomk ivanleomk merged commit a54ea2d into main Oct 29, 2024
14 of 15 checks passed
@ivanleomk ivanleomk deleted the fix-oai-invalid-body branch October 29, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant