Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: convert_messages drops tool_call_id field (and other fields) #1164 #1170

Closed
wants to merge 2 commits into from
Closed

fix: convert_messages drops tool_call_id field (and other fields) #1164 #1170

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23f938c
convert_messages drops tool_call_id field (and other fields) #1164
chiradeepv Nov 12, 2024
feb7b50
Merge branch 'main' into fix_convert_messages
jxnl Nov 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion instructor/multimodal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,7 @@ def is_image_params(x: Any) -> bool:
cast(ImageParams, content)
)
if isinstance(content, str):
converted_messages.append({"role": role, "content": content}) # type: ignore
converted_messages.append(message) # type: ignore
else:
converted_content = convert_contents(content, mode)
converted_messages.append({"role": role, "content": converted_content}) # type: ignore
Expand Down