Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed up tenacity link #1173

Merged
merged 1 commit into from
Nov 13, 2024
Merged

fix: fixed up tenacity link #1173

merged 1 commit into from
Nov 13, 2024

Conversation

ivanleomk
Copy link
Collaborator

@ivanleomk ivanleomk commented Nov 13, 2024

Important

Fixes hyperlink in chat-with-your-pdf-with-gemini.md to correctly point to retry logic documentation.

  • Documentation:
    • Fixes hyperlink in chat-with-your-pdf-with-gemini.md to correctly point to ../../concepts/retrying.md for custom retry logic using tenacity.

This description was created by Ellipsis for 0b49ff9. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 0b49ff9 in 14 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. docs/blog/posts/chat-with-your-pdf-with-gemini.md:96
  • Draft comment:
    The link to the tenacity documentation has been correctly fixed. Ensure all other links in the document are also verified for accuracy.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR fixes a broken link by adding the correct path to the tenacity documentation. This is a straightforward fix and aligns with the intent of the PR.
2. docs/blog/posts/chat-with-your-pdf-with-gemini.md:96
  • Draft comment:
    Ensure that the new retrying.md file is added to the mkdocs.yml file to maintain documentation consistency.
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_nfNhdC1UOmPG1sB1


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@github-actions github-actions bot added documentation Improvements or additions to documentation size:S This PR changes 10-29 lines, ignoring generated files. labels Nov 13, 2024
Copy link

Deploying instructor-py with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0b49ff9
Status: ✅  Deploy successful!
Preview URL: https://6a4f5bae.instructor-py.pages.dev
Branch Preview URL: https://fix-docs-link.instructor-py.pages.dev

View logs

@ivanleomk ivanleomk merged commit 405a1ee into main Nov 13, 2024
15 of 16 checks passed
@ivanleomk ivanleomk deleted the fix-docs-link branch November 13, 2024 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant