Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump jiter #1178

Closed
wants to merge 2 commits into from
Closed

fix: bump jiter #1178

wants to merge 2 commits into from

Conversation

ivanleomk
Copy link
Collaborator

@ivanleomk ivanleomk commented Nov 14, 2024

Important

Update jiter to 0.7.1 and pydantic_extra_types to ^2.10.0 in pyproject.toml.

  • Dependencies:
    • Update jiter version from >=0.5,<0.7 to 0.7.1 in pyproject.toml.
    • Update pydantic_extra_types version from ^2.6.0 to ^2.10.0 in pyproject.toml.

This description was created by Ellipsis for 9e76805. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to e1723d2 in 12 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 1 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. pyproject.toml:21
  • Draft comment:
    Specifying a fixed version for jiter (0.7.1) instead of a range can prevent automatic updates for patch versions. Consider using a range like >=0.7.1,<0.8.0 to allow for future patch updates.
  • Reason this comment was not posted:
    Confidence changes required: 80%
    The change in the jiter dependency version from a range to a specific version can cause issues if there are any backward-incompatible changes in future versions. It's generally better to specify a range to allow for patch updates.
2. pyproject.toml:21
  • Draft comment:
    When updating the jiter library version, ensure that related documentation and tests are updated accordingly.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_k4P4jwOnjAwgmtL0


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Nov 14, 2024
Copy link

cloudflare-workers-and-pages bot commented Nov 14, 2024

Deploying instructor-py with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9e76805
Status: ✅  Deploy successful!
Preview URL: https://39e04789.instructor-py.pages.dev
Branch Preview URL: https://bump-jiter-to-0-7.instructor-py.pages.dev

View logs

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 9e76805 in 17 seconds

More details
  • Looked at 22 lines of code in 1 files
  • Skipped 1 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. pyproject.toml:31
  • Draft comment:
    The PR description only mentions updating the jiter dependency, but this line shows an update to pydantic_extra_types as well. Ensure the PR description accurately reflects all changes made.
  • Reason this comment was not posted:
    Confidence changes required: 80%
    The PR description mentions updating the jiter dependency, but the diff shows changes to pydantic_extra_types as well. This should be clarified or corrected.
2. pyproject.toml:31
  • Draft comment:
    If pydantic_extra_types library code changes, ensure that relevant documentation and tests are updated accordingly.
  • Reason this comment was not posted:
    Confidence changes required: 80%
    The PR updates the pydantic_extra_types dependency in pyproject.toml, but there is no mention of updating documentation or tests related to this change. Since pydantic_extra_types is a library dependency, it's important to ensure that any relevant documentation and tests are updated accordingly.

Workflow ID: wflow_czBMunsQFSDrWmYq


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@ivanleomk ivanleomk closed this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant