Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added deepseek page #1214

Merged
merged 2 commits into from
Nov 24, 2024
Merged

feat: added deepseek page #1214

merged 2 commits into from
Nov 24, 2024

Conversation

ivanleomk
Copy link
Collaborator

@ivanleomk ivanleomk commented Nov 24, 2024

This adds documentation for instructor on how to use deepseek with us :)


Important

Adds DeepSeek integration documentation with examples to the Instructor project and updates navigation in mkdocs.yml.

  • Documentation:
    • Adds deepseek.md to docs/integrations/ with a comprehensive guide on using DeepSeek with Instructor.
    • Includes examples for synchronous, asynchronous, nested, and streaming use cases.
  • Configuration:
    • Updates mkdocs.yml to include DeepSeek in the navigation under Integrations.

This description was created by Ellipsis for 7f0988b. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 7f0988b in 17 seconds

More details
  • Looked at 301 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. docs/integrations/deepseek.md:114
  • Draft comment:
    Duplicate import of BaseModel. Remove this line to clean up the code. This issue is also present on lines 185 and 230.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The import statement for BaseModel from pydantic is duplicated in several code examples. This is unnecessary and can be removed to clean up the code.
2. docs/integrations/deepseek.md:114
  • Draft comment:
    The import statement for BaseModel from pydantic is repeated. Consider removing the duplicate import on line 114 to adhere to the DRY principle.
  • Reason this comment was not posted:
    Confidence changes required: 80%
    The import statement for BaseModel from pydantic is repeated in several code examples. This violates the DRY principle.

Workflow ID: wflow_T4BRNgRoDUZn7x0t


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New feature or request size:M This PR changes 30-99 lines, ignoring generated files. labels Nov 24, 2024
Copy link

cloudflare-workers-and-pages bot commented Nov 24, 2024

Deploying instructor-py with  Cloudflare Pages  Cloudflare Pages

Latest commit: 99aad2f
Status: ✅  Deploy successful!
Preview URL: https://3954d0e6.instructor-py.pages.dev
Branch Preview URL: https://add-deepseek.instructor-py.pages.dev

View logs

@ivanleomk ivanleomk merged commit 1675157 into main Nov 24, 2024
14 of 15 checks passed
@ivanleomk ivanleomk deleted the add-deepseek branch November 24, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant