Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new article on migrating to uv #1284

Merged
merged 1 commit into from
Dec 26, 2024
Merged

feat: add new article on migrating to uv #1284

merged 1 commit into from
Dec 26, 2024

Conversation

ivanleomk
Copy link
Collaborator

@ivanleomk ivanleomk commented Dec 26, 2024

Adding new article that walks through issues we faced when migrating to uv

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to c6e865c in 33 seconds

More details
  • Looked at 239 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. docs/blog/posts/migrating-to-uv.md:44
  • Draft comment:
    Typo: 'pyprpoejct.toml' should be 'pyproject.toml'.
  • Reason this comment was not posted:
    Confidence changes required: 10%
    The word 'pyprpoejct.toml' is misspelled and should be corrected to 'pyproject.toml'.
2. docs/blog/posts/migrating-to-uv.md:233
  • Draft comment:
    Ensure this new markdown file is added to mkdocs.yml to be included in the documentation.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable:
    The comment aligns with one of our additional rules about ensuring new md files are added to mkdocs.yml. This is a new file being added, and it's in the docs directory. Blog posts are typically part of the documentation structure and need to be included in mkdocs.yml to be visible.
    The file is in docs/blog/posts - maybe blog posts are automatically included through a pattern match in mkdocs.yml and don't need manual addition? Without seeing mkdocs.yml, we can't be completely certain.
    Even if there's a chance blog posts are auto-included, it's better to be safe than sorry with documentation visibility. The cost of checking mkdocs.yml is low compared to the risk of the post being invisible.
    Keep the comment since it enforces an important documentation rule and helps ensure the blog post will be visible.

Workflow ID: wflow_hn5LTwXmXbqnhBYr


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New feature or request size:M This PR changes 30-99 lines, ignoring generated files. labels Dec 26, 2024
Copy link

Deploying instructor-py with  Cloudflare Pages  Cloudflare Pages

Latest commit: c6e865c
Status: ✅  Deploy successful!
Preview URL: https://8a303a82.instructor-py.pages.dev
Branch Preview URL: https://uv-migration.instructor-py.pages.dev

View logs

@ivanleomk ivanleomk merged commit e1ae9e3 into main Dec 26, 2024
15 of 16 checks passed
@ivanleomk ivanleomk deleted the uv-migration branch December 26, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant