New Logfire Article ( Fixes #640 ) #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying instructor with
|
| Latest commit: |
e9aecf3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f10f7b75.instructor.pages.dev |
| Branch Preview URL: | https://logfire-fastapi.instructor.pages.dev |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested.
- Reviewed the entire pull request up to 42bc099
- Looked at
371lines of code in8files - Took 55 seconds to review
More info
- Skipped
0files when reviewing. - Skipped posting
0additional comments because they didn't meet confidence threshold of85%.
Workflow ID: wflow_63xqnjpaqLnNT2gR
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with review rules, user-specific overrides, quiet mode, and more. See docs.
boydgreenfield
pushed a commit
to boydgreenfield/instructor
that referenced
this pull request
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new PR fixes #640 and introduces a new article + code on how to use instructor with Asyncio. It showcases two examples - one with simple classification and another with the streaming API.
Summary:
Introduces a comprehensive guide and example on integrating Logfire with FastAPI and Instructor for enhanced application telemetry.
Key points:
full-fastapi-visibility.mdin/docs/blog/postsexplaining the integration of Logfire with FastAPI and Instructor./examples/logfire-fastapidemonstrating practical implementation of the discussed features./docs/blog/posts/imgfor visual aid in the article.Generated with ❤️ by ellipsis.dev