Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBL-18197][Teacher][Student][A11y] Add avatar action description #2693

Closed
wants to merge 5 commits into from
Closed

[MBL-18197][Teacher][Student][A11y] Add avatar action description #2693

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d8ce2fb
add action description
hermannakos Jan 7, 2025
77c94dc
fix tests
hermannakos Jan 27, 2025
093cd85
Merge branch 'master' into MBL-18197-a11y-inbox-avatar-content-descri…
hermannakos Jan 27, 2025
3302d1d
Merge branch 'master' into MBL-18197-a11y-inbox-avatar-content-descri…
hermannakos Jan 27, 2025
3c608b2
test fix
hermannakos Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions libs/pandares/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1963,4 +1963,5 @@
<string name="smartSearchDiscussionGroupTitle">Discussion topics (%d)</string>
<string name="smartSearchAssignmentGroupTitle">Assignments (%d)</string>
<string name="smartSearchPageGroupTitle">Pages (%d)</string>
<string name="a11y_avatarActionDescription">Open profile</string>
</resources>
19 changes: 18 additions & 1 deletion libs/pandautils/src/main/java/com/instructure/pandautils/binding/BindingAdapters.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,8 +276,25 @@ fun bindUserAvatar(imageView: ImageView, avatar: AvatarViewData) {
imageView.importantForAccessibility = View.IMPORTANT_FOR_ACCESSIBILITY_NO
} else {
imageView.importantForAccessibility = View.IMPORTANT_FOR_ACCESSIBILITY_YES
imageView.contentDescription = imageView.context.getString(R.string.a11y_avatarContentDescription)
ProfileUtils.loadAvatarForUser(imageView, avatar.firstUserName, avatar.avatarUrl)
imageView.accessibilityDelegate = object : View.AccessibilityDelegate() {
override fun onInitializeAccessibilityNodeInfo(
host: View,
info: AccessibilityNodeInfo
) {
super.onInitializeAccessibilityNodeInfo(host, info)
info.contentDescription = imageView.context.getString(
R.string.a11y_avatarContentDescription,
avatar.firstUserName
)
info.addAction(
AccessibilityNodeInfo.AccessibilityAction(
AccessibilityNodeInfo.ACTION_CLICK,
imageView.context.getString(R.string.a11y_avatarActionDescription)
)
)
}
}
}
}

Expand Down