Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Horizon] Merge master #3181

Open
wants to merge 153 commits into
base: feature/horizon
Choose a base branch
from
Open

[Horizon] Merge master #3181

wants to merge 153 commits into from

Conversation

szabinst
Copy link
Contributor

Merges latest changes from master.

inst-danger and others added 30 commits October 15, 2024 13:33
@inst-danger
Update translations (#2929)
8ff9f40 
[ignore-commit-lint]
@Ahmed-Naguib93
Change letter grade when toggling based on graded assignments on grad…
5645dab 
…e screen (#2920)

refs:MBL-17951
affects: Student, Parent
release note: none

test plan:
@vargaat
Add baseURL to webview. (#2924)
00c1531 
refs: MBL-17939
affects: Teacher
release note: Fixed LTI content embedded in RCE submissions not displaying in SpeedGrader.

test plan: See ticket
@vargaat
Fix file parsing failing when filename is null. Fix offline content s…
f61c4dd 
…elector screen not reacting to cancel when in error or loading states. (#2926)

refs: MBL-17877
affects: Student
release note: Fixed cancel not working on offline sync picker screen while the screen is loading or displaying an error. Fixed offline sync picker failing to load in some cases.

test plan: See ticket.
@vargaat
Upload dSYMs (#2922)
4dee1cd 
[ignore-commit-lint]
@Ahmed-Naguib93
Enable sending messages to an unlimited number of recipients (#2923)
bbd7048 
refs: MBL-17936
affects: Student, Teacher
release note: Fixed an issue that prevented sending messages to more than 100 people.

test plan:
@szabinst
Move Student QuizDetails to Core (#2937)
8a720cc 
[ignore-commit-lint]
@rh12
Fix Observer Alert list (#2925)
d32428b 
refs: MBL-17893
affects: Parent
release note: Fixed alert list not refreshing after an alert is read or dismissed.
@vargaat
Remove unnecessary color contrast calculation. (#2939)
96f0836 
[ignore-commit-lint]
@Ahmed-Naguib93
Fixed an issue where pasting long text and typing in the middle moved…
42959c9 
… the cursor to the end. (#2927)

refs: MBL-17838
affects: Student, Teacher
release note: Fixed issues after pasting long text in inbox messages.
@rh12
Calendar Filter crash (#2938)
ac89807 
refs: MBL-17976
affects: Student, Teacher, Parent
release note: none
@balintbartok
Update CODEOWNERS
7f74b69
@suhaibabsi-inst
Fix issues of Xcode 16 (#2899)
17f75e0 
refs: MBL-17890
affects: Student, Teacher, Parent
release note: none

test plan:
@Ahmed-Naguib93
Show media from media comment in the Inbox (#2940)
e7814a6 
refs: MBL-17959
affects: Teacher, Student
release note: Inbox messages now show attached audio/video comments.

test plan:
@Ahmed-Naguib93
Show assignments in grade list depend on hideInGradeBook flag (#2943)
c7b074d 
refs: MBL-17944
affects: Student, Parent
release note: Fixed some assignments being visible on the grades screen when the shouldn't be.

test plan:
@ndrsszsz
Automation - E2E test maintenance (#2945)
c47b62e 
refs: MBL-18022
affects: none
release note: none

test plan: Tests to pass
@Ahmed-Naguib93
Enable add recipients when reply from web (#2931)
d1ade3d 
refs: MBL-17936
affects: Teacher, Student
release note: none

test plan:
@rh12
Calendar event custom frequency prefill (#2946)
415c02d 
refs: MBL-17971
affects: Student, Teacher
release note: Custom calendar frequency screen now reuses the currently selected frequency.

test plan: See PR description
@vargaat
No file verifiers (#2941)
49d9fff 
refs: MBL-17864
affects: Student, Teacher, Parent
release note: none

test plan:
- Log in to the beta environment.
- Link course files to where rich content is enabled using a web browser. (Assignment, quiz, discussion, announcement, page, syllabus, calendar event)
- Check the linked files is they are still working from the apps.
@inst-danger
Update translations (#2953)
54c0bb9 
[ignore-commit-lint]
@suhaibabsi-inst
Fix the issue of missing Indicator of unread messages on Inbox icon (#…
66815c5 
…2955)

* Fix inbox tab badge value

* Update count on main queue

refs: MBL-18045
affects: Student,Teacher
release note: Fix the issue of missing Indicator of unread messages on Inbox icon

test plan: See PR description

* Fix unit tests

* Update InboxMessageInteractorLiveTests.swift

* Update FileSubmissionItemsUploadStarterTests.swift
@suhaibabsi-inst
Fix the issue of annotation bar move button being cut off on landscap…
4548dd4 
…e mode (#2957)

refs: MBL-17988
affects: Student,Teacher
release note: Fix the issue of annotation bar move button being cut off on landscape mode.

test plan: See PR description
@rh12
Update GetWebSessionRequest to support masquerading (#2958)
8466bb5 
refs: MBL-17910
affects: Student, Teacher, Parent
release note: none

test plan: See PR description
@rh12
Swift Style Guide proposal (#2915)
04462c3 
[ignore-commit-lint]
@kdeakinstructure
Implement Assignments Offline E2E test case (#2956)
8cae588 
* refs: MBL-18034
affects: Student
release note: none

Implement Offline Assignments E2E test case.
Add new helper (OfflineHelper) for Offline mode dialog (and future usage).

* Minor refactor.

* Update .gitignore

* Refactor according to PR comments.

* Remove Package.resolved from gitignore

* Delete screenlog.0

* Delete Brewfile.lock.json

* Remove trailing whitespaces in whitespace-only lines.

* Remove trailing whitespace from DashboardHelper
@ndrsszsz
Assignment List Preferences (Filter, GroupBy, Grading Period) (#2948)
cb2f937 
refs: MBL-14876
affects: Student, Teacher
release note: Added filtering and sorting options to assignment list.
test plan: See ticket
@vargaat
Fix offline file loading logic (#2960)
48b719f 
refs: MBL-17935
affects: Student
release note: Fixed downloaded files not being available in offline mode.

test plan:
- Have a course with a course file added to modules.
- Sync the course with files for offline mode.
- Go offline.
- Enter the course's Files menu.
- Check if the downloaded file displays in the file viewer.
- Go to Modules, test if the linked file in the module item it will display in offline mode.
- Smoke test if files are working in online mode.
@rh12
Startup crash on iPads running iOS 18 (#2966)
49f16e3 
* Fix startup crash

refs: MBL-18078
affects: Student, Teacher
release note: Fixed a startup crash which occurred on some devices.

test plan:

* Fix always visible Back Online banner
@inst-danger
Update translations (#2964)
b69f334 
[ignore-commit-lint]
@rh12
Inbox messages truncated (#2968)
7016061 
refs: MBL-18051
affects: Student, Teacher
release note: Fixed the end of inbox messages not being displayed in some cases.

test plan: See PR description
rh12 and others added 17 commits February 17, 2025 18:38
@rh12
Accessibility - Add number of items to a11y label in AssignmentList s…
cc24038 
…ections (#3157)

refs: MBL-18480
affects: Student, Teacher
release note: none
@rh12
Accessibility - Improve a11y of Speedgrader Grades-Comments-Files tabs (
91e409d 
#3156)

refs: MBL-18443
affects: Teacher
release note: none
@suhaibabsi-inst
Accessibility - Student - Lists Count Announcement For Offline Conten…
df42551 
…t Screen (#3162)

refs: MBL-18373
affects: Student
release note: none
@vargaat
Accessibility - Student/Parent - Add grade list filter change announc…
1ccddbb 
…ement (#3147)

refs: MBL-18462
affects: Student, Parent
release note: none

test plan:
- Check if changing the grading filter and closing the modal with the done button announces that the filter was applied.
@vargaat
Add expanded state value to student switcher button. (#3141)
eaa18ab 
refs: MBL-18409
affects: Parent
release note: none

test plan:
- Ensure expanded state value is announced on student switcher button.
@vargaat
Accessibility - Student - Focus voiceover on sync progress card (#3153)
4dcdf4d 
refs: MBL-18375
affects: Student
release note: none

test plan:
- Start an offline sync.
- Voiceover focus should jump to the sync progress card after modals have been dismissed and shuld announce what's happening.
@suhaibabsi-inst
Fixes Accessibility Focus Order of Recipients Field of Parent's Compo…
93b2773 
…se Message Form (#3163)

refs: MBL-18356
affects: Parent
release note: None
@ndrsszsz
Accessibility - Student - SubmissionDetails - Set VoiceOver focus on …
ff1903d 
…changing tabs on drawer (#3168)

refs: MBL-18385
affects: Student
release note: None
test plan: See ticket.
@rh12
Accessibility - Inbox Recipients list count (#3169)
5181f50 
refs: MBL-18348
affects: Student, Teacher
release note: none
@suhaibabsi-inst
Fix the issue of detail view of SplitViewController when switching ou…
c6498e6 
…t-in the app (#3118)

refs: MBL-18549
affects: Student, Teacher
release note: Fixed the issue where app doesn't refresh shown page properly after switching to another app
@vargaat
Fix long press on rubric (#3138)
f4dfd98 
refs: MBL-18567
affects: Teacher
release note: Fixed long tap gesture on rubric ratings in SpeedGrader.

test plan:
- As the teacher create an assignment that has a rubric associated to it.
- Log in to the Canvas Teacher app on an iOS device.
- Open the assignment.
- Navigate to the Submissions section and select a student to grade.
- Swipe up to open the grade details section.
- Tap and hold on one of the rubric ratings.
- The rating's title should be revealed.
@rh12
Unify Navigation bar titles (#3129)
26e1ca0 
refs: MBL-18460
affects: Student, Teacher, Parent
release note: none
@suhaibabsi-inst
Move Focus to Student Avatar on Switching to Tab (#3172)
546cb7f 
refs: MBL-18400
affects: Parent
release note: None.
@suhaibabsi-inst
Accessibility - Parent - Move focus to percent label when Grades tab …
d6ac30a 
…is selected (#3164)

refs: MBL-18415
affects: Parent
release note: None
@ndrsszsz
Accessibility - Chat/Inbox - Add title to attachment picker (#3155)
1c19beb 
refs: MBL-18358
affects: Parent
release note: None
test plan: See ticket.
@szabinst
Merge remote-tracking branch 'origin/master' into feature/horizon-mer…
cdb2e79 
…ge-master

# Conflicts:
#	.github/CODEOWNERS
#	.gitignore
#	.swiftlint.yml
#	Core/Core/Common/CommonModels/AppEnvironment/AppEnvironment.swift
#	Core/Core/Common/CommonUI/InstUI/Views/NavigationBarTitleView.swift
#	Core/Core/Common/CommonUI/NavigationBar/SwiftUI/NavigationBarViewModifiers.swift
#	Core/Core/Common/CommonUI/NavigationBar/UIKit/ColoredNavViewProtocol.swift
#	Core/Core/Common/CommonUI/NavigationBar/UIKit/TitleSubtitleView.swift
#	Core/Core/Common/CommonUI/NavigationBar/UIKit/TitleSubtitleView.xib
#	Core/Core/Common/CommonUI/NavigationBar/UIKit/UINavigationBarExtensions.swift
#	Core/Core/Common/CommonUI/Presenter/ColoredNavViewProtocol.swift
#	Core/Core/Common/CommonUI/SwiftUIViews/UIKitSwiftUIBridging/CoreHostingController.swift
#	Core/Core/Common/CommonUI/SwiftUIViews/UIKitSwiftUIBridging/UINavigationControllerTheme.swift
#	Core/Core/Common/CommonUI/UIViews/ItemPickerViewController.swift
#	Core/Core/Common/CommonUI/UIViews/TitleSubtitleView.swift
#	Core/Core/Common/CommonUI/UIViews/TitleSubtitleView.xib
#	Core/Core/Common/Extensions/Foundation/CGSizeExtensions.swift
#	Core/Core/Common/Extensions/Foundation/StringExtensions.swift
#	Core/Core/Common/Extensions/UIKit/UINavigationBarExtensions.swift
#	Core/Core/Extensions/HTTPCookieExtensions.swift
#	Core/Core/Extensions/LoggerExtensions.swift
#	Core/Core/Extensions/UINavigationBarExtensions.swift
#	Core/Core/Features/Assignments/AssignmentList/View/AssignmentGroupView.swift
#	Core/Core/Features/Assignments/AssignmentList/View/AssignmentListPreferencesScreen.swift
#	Core/Core/Features/Assignments/AssignmentList/View/AssignmentListScreen.swift
#	Core/Core/Features/Courses/SmartSearch/View/CourseSmartSearchFilterEditorView.swift
#	Core/Core/Features/Courses/SmartSearch/View/CourseSmartSearchHelpView.swift
#	Core/Core/Features/Files/View/FileDetails/FileDetailsViewController.swift
#	Core/Core/Features/Grades/View/GradeFilterView.swift
#	Core/Core/Features/Grades/ViewModel/GradeFilterViewModel.swift
#	Core/Core/Features/Inbox/AttachmentPicker/Model/AttachmentPickerInteractor/AttachmentPickerInteractor.swift
#	Core/Core/Features/Inbox/AttachmentPicker/Model/AttachmentPickerInteractor/AttachmentPickerInteractorLive.swift
#	Core/Core/Features/Inbox/AttachmentPicker/Model/AttachmentPickerInteractor/AttachmentPickerInteractorPreview.swift
#	Core/Core/Features/Inbox/AttachmentPicker/View/AttachmentPickerView.swift
#	Core/Core/Features/Inbox/AttachmentPicker/ViewModel/AttachmentPickerViewModel.swift
#	Core/Core/Features/Inbox/ComposeMessage/View/UITextViewWrapper.swift
#	Core/Core/Features/Planner/CalendarEvent/View/SelectEventFrequencyScreen.swift
#	Core/Core/Features/Planner/CalendarSelector/View/SelectCalendarScreen.swift
#	Core/Core/Features/Search/View/CoreSearchHostingController.swift
#	Core/Core/Features/Search/View/SearchViewsProvider.swift
#	Core/Core/Features/SubmitAssignmentExtension/View/SubmitAssignmentExtensionView.swift
#	Core/Core/Inbox/AttachmentPicker/Model/AttachmentPickerInteractor/AttachmentPickerInteractor.swift
#	Core/Core/InstUI/Views/ListSectionHeader.swift
#	Core/Core/Presenter/ColoredNavViewProtocol.swift
#	Core/Core/Resources/Localizable.xcstrings
#	Core/Core/SwiftUIViews/UIKitSwiftUIBridging/UINavigationControllerTheme.swift
#	Core/Core/UIViews/TitleSubtitleView.swift
#	Core/Core/UIViews/TitleSubtitleView.xib
#	Core/CoreTests/Common/CommonUI/CoreWebView/View/CoreWebViewTests.swift
#	Core/CoreTests/Common/CommonUI/NavigationBar/UIKit/TitleSubtitleViewTests.swift
#	Core/CoreTests/Common/CommonUI/NavigationBar/UIKit/UINavigationBarExtensionsTests.swift
#	Core/CoreTests/Common/CommonUI/UIViews/BottomSheetPickerViewControllerTests.swift
#	Core/CoreTests/Common/CommonUI/UIViews/TitleSubtitleViewTests.swift
#	Core/CoreTests/Common/Extensions/Foundation/StringExtensionsTests.swift
#	Core/CoreTests/Common/Extensions/UIKit/UINavigationBarExtensionsTests.swift
#	Core/CoreTests/Common/Extensions/WebKit/WKWebViewExtensionsTests.swift
#	Core/CoreTests/CoreWebView/View/CoreWebViewControllerTests.swift
#	Core/CoreTests/Extensions/UINavigationBarExtensionsTests.swift
#	Core/CoreTests/Features/Courses/SmartSearch/Model/CourseSmartSearchViewAttributesTests.swift
#	Core/CoreTests/Features/Grades/Model/GradeListInteractorLiveTests.swift
#	Core/CoreTests/Features/Inbox/AttachmentPicker/Model/AttachmentPickerInteractorLiveTests.swift
#	Core/CoreTests/Features/Inbox/AttachmentPicker/ViewModel/AttachmentPickerViewModelTests.swift
#	Core/CoreTests/Features/Planner/CalendarEvent/Model/Helpers/RecurrenceRule+SelectionDescriptionTests.swift
#	Core/CoreTests/Features/SubmitAssignmentExtension/Model/API/AssignmentPickerListServiceTests.swift
#	Core/CoreTests/TestHelpers/CoreTestCase.swift
#	Core/CoreTests/UIViews/TitleSubtitleViewTests.swift
#	Parent/Parent/Dashboard/DashboardViewController.swift
#	Parent/Parent/Localizable.xcstrings
#	Parent/Parent/ObserverAlerts/Model/UseCase/DismissObserverAlert.swift
#	Student/Student/StudentAppDelegate.swift
#	Teacher/Teacher/Routes.swift
#	Teacher/Teacher/SpeedGrader/SubmissionCommentList.swift
#	packages/HorizonUI/Sources/HorizonUI/Sources/Components/Cards/HorizonUI.Card.Stroybook.swift
#	packages/HorizonUI/Sources/HorizonUI/Sources/Components/Controls/HorizonUI.Controls.swift
@szabinst
Merge remote-tracking branch 'origin/master' into feature/horizon-mer…
a6abff5 
…ge-master

[ignore-commit-lint]
@szabinst szabinst self-assigned this Feb 21, 2025
@inst-danger
Copy link
Contributor

inst-danger commented Feb 21, 2025 •
edited
Loading

Horizon Build QR Code:

@inst-danger
Copy link
Contributor

inst-danger commented Feb 21, 2025 •
edited
Loading

Warnings
⚠️ One or more files are below the minimum test coverage 50%
Coverage New % Master % Delta
Canvas iOS 91.17% 91.68% -0.52%
Core/Core/Features/Notifications/UserNotificationCenterDelegate.swift 9.38% -- --
Core/Core/Features/Courses/CourseProgression/GetCoursesProgressionUseCase.swift 0% -- --
Core/Core/Features/Courses/CourseProgression/GetCoursesProgressionRequest.swift 0% -- --
Core/Core/Features/Courses/CourseProgression/CDCourseProgression.swift 0% -- --
Core/Core/Features/Modules/MarkModuleItemRead.swift 0% -- --
Core/Core/Features/Modules/MarkModuleItemDone.swift 0% -- --

Generated by 🚫 dangerJS against 4310d58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktheory ktheory Awaiting requested review from ktheory ktheory is a code owner

@JacksonHowe JacksonHowe Awaiting requested review from JacksonHowe JacksonHowe is a code owner

@Ahmed-Naguib93 Ahmed-Naguib93 Awaiting requested review from Ahmed-Naguib93 Ahmed-Naguib93 is a code owner

@reabbotted reabbotted Awaiting requested review from reabbotted reabbotted is a code owner

@vargaat vargaat Awaiting requested review from vargaat vargaat is a code owner

@rh12 rh12 Awaiting requested review from rh12 rh12 is a code owner

@ndrsszsz ndrsszsz Awaiting requested review from ndrsszsz ndrsszsz is a code owner

@suhaibabsi-inst suhaibabsi-inst Awaiting requested review from suhaibabsi-inst suhaibabsi-inst is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@szabinst szabinst

Labels
horizon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@szabinst @inst-danger @Ahmed-Naguib93 @vargaat @rh12 @balintbartok @suhaibabsi-inst @ndrsszsz @kdeakinstructure