WIP(ui-breadcrumb,ui-test-utils): update

instructure · Oct 5, 2023 · 87b2bc7 · 87b2bc7
1 parent 689e505
commit 87b2bc7
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 30 deletions.
diff --git a/packages/ui-breadcrumb/src/Breadcrumb/__tests__/Breadcrumb.test.tsx b/packages/ui-breadcrumb/src/Breadcrumb/__tests__/Breadcrumb.test.tsx
@@ -22,42 +22,41 @@
  * SOFTWARE.
  */
 
-// import React from 'react'
+import React from 'react'
 
-// import { expect, mount, generateA11yTests } from '@instructure/ui-test-utils'
-import { generateA11yTests } from '@instructure/ui-test-utils'
+import { expect, mount, generateA11yTests } from '@instructure/ui-test-utils'
 
 import { Breadcrumb } from '../index'
-// import { BreadcrumbLocator } from '../BreadcrumbLocator'
+import { BreadcrumbLocator } from '../BreadcrumbLocator'
 import BreadcrumbExamples from '../__examples__/Breadcrumb.examples'
 
 describe('<Breadcrumb />', async () => {
-  // it('should render the label as an aria-label attribute', async () => {
-  //   await mount(
-  //     <Breadcrumb label="Settings">
-  //       <Breadcrumb.Link>Account</Breadcrumb.Link>
-  //     </Breadcrumb>
-  //   )
-  //   const breadcrumb = await BreadcrumbLocator.find()
-  //   const label = await breadcrumb.find(':label(Settings)')
-  //
-  //   expect(label.getAttribute('aria-label')).to.equal('Settings')
-  // })
+  it('should render the label as an aria-label attribute', async () => {
+    await mount(
+      <Breadcrumb label="Settings">
+        <Breadcrumb.Link>Account</Breadcrumb.Link>
+      </Breadcrumb>
+    )
+    const breadcrumb = await BreadcrumbLocator.find()
+    const label = await breadcrumb.find(':label(Settings)')
+
+    expect(label.getAttribute('aria-label')).to.equal('Settings')
+  })
 
   describe('with generated examples', async () => {
     generateA11yTests(Breadcrumb, BreadcrumbExamples)
   })
 
-  // it('should render an icon as a separator', async () => {
-  //   await mount(
-  //     <Breadcrumb label="Settings">
-  //       <Breadcrumb.Link href="#">Account</Breadcrumb.Link>
-  //       <Breadcrumb.Link>Settings</Breadcrumb.Link>
-  //     </Breadcrumb>
-  //   )
-  //   const breadcrumb = await BreadcrumbLocator.find()
-  //   const icon = await breadcrumb.find('svg')
-  //
-  //   expect(icon.getAttribute('aria-hidden')).to.equal('true')
-  // })
+  it('should render an icon as a separator', async () => {
+    await mount(
+      <Breadcrumb label="Settings">
+        <Breadcrumb.Link href="#">Account</Breadcrumb.Link>
+        <Breadcrumb.Link>Settings</Breadcrumb.Link>
+      </Breadcrumb>
+    )
+    const breadcrumb = await BreadcrumbLocator.find()
+    const icon = await breadcrumb.find('svg')
+
+    expect(icon.getAttribute('aria-hidden')).to.equal('true')
+  })
 })
diff --git a/packages/ui-test-utils/src/utils/generateComponentExamples.ts b/packages/ui-test-utils/src/utils/generateComponentExamples.ts
@@ -22,7 +22,7 @@
  * SOFTWARE.
  */
 
-// import { nanoid } from 'nanoid'
+import { nanoid } from 'nanoid'
 
 import { generatePropCombinations } from './generatePropCombinations'
 import React, { ComponentType, ReactNode } from 'react'
@@ -241,8 +241,7 @@ export function generateComponentExamples<Props extends Record<string, any>>(
     }
     const propsString = fastSerialize(componentProps)
     if (!PROPS_CACHE.includes(propsString)) {
-      // const key = nanoid()
-      const key = '' + Math.round(Math.random() * 10000)
+      const key = nanoid()
       const exampleProps = getExampleProps(props)
       exampleCount++
       if (exampleCount < maxExamples) {