fix double mount/unmount in ui-tray

instructure · Oct 11, 2023 · f432c6d · f432c6d
1 parent 9f3e0f5
commit f432c6d
Showing 1 changed file with 15 additions and 19 deletions.
diff --git a/packages/ui-tray/src/Tray/index.tsx b/packages/ui-tray/src/Tray/index.tsx
@@ -201,25 +201,21 @@ class Tray extends Component<TrayProps> {
               css={this.props.styles?.tray}
               ref={contentRef}
             >
-              {this.state.transitioning ? (
-                children
-              ) : (
-                <Dialog
-                  as="div"
-                  label={label}
-                  defaultFocusElement={defaultFocusElement}
-                  open
-                  shouldContainFocus={shouldContainFocus}
-                  shouldReturnFocus={shouldReturnFocus}
-                  shouldCloseOnDocumentClick={shouldCloseOnDocumentClick}
-                  shouldCloseOnEscape
-                  liveRegion={liveRegion}
-                  onDismiss={onDismiss}
-                  role={role}
-                >
-                  <div css={this.props.styles?.content}>{children}</div>
-                </Dialog>
-              )}
+              <Dialog
+                as="div"
+                label={label}
+                defaultFocusElement={defaultFocusElement}
+                open
+                shouldContainFocus={shouldContainFocus}
+                shouldReturnFocus={shouldReturnFocus}
+                shouldCloseOnDocumentClick={shouldCloseOnDocumentClick}
+                shouldCloseOnEscape
+                liveRegion={liveRegion}
+                onDismiss={onDismiss}
+                role={role}
+              >
+                <div css={this.props.styles?.content}>{children}</div>
+              </Dialog>
             </span>
           </Transition>
         )}