chore: remove gulp and migrate icon build scripts to ui-scripts #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview URL: https://1298--preview-instui.netlify.app |
balzss
force-pushed
the
chore/remove-gulp
branch
from
9b9b755 to
9a8feb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INSTUI-3843
test plan:
npm run bootstrapwill do that) and copy it outside the repopackages/ui-icons/__build__folder (just to be sure) and runnpm run bootstrapto regenerate it__build__/index.tsfile with the one from master__build__/svg/index.jsfile with the one from master__build__/fontswere generated correctly (it's still done via gulp, so only check if the files are there, no need to open and compare)