Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ui-breadcrumb): migrate old Breadcrumb tests #1307

Merged

Conversation

git-nandor
Copy link
Contributor

Closes: INSTUI-3865

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Preview URL: https://1307--preview-instui.netlify.app

@git-nandor git-nandor marked this pull request as ready for review October 6, 2023 08:39
@balzss
Copy link
Contributor

balzss commented Oct 6, 2023

let's wait until #1308 is merged so the generated a11y tests can be added to this PR

Copy link
Contributor

@joyenjoyer joyenjoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job with the ResizeObserver mock

@git-nandor git-nandor self-assigned this Oct 11, 2023
@git-nandor git-nandor force-pushed the INSTUI-3865_convert_ui-breadcrumb_to_the_new_testing_format branch 3 times, most recently from bd2353f to 7223dc7 Compare October 12, 2023 11:23
@git-nandor git-nandor requested a review from joyenjoyer October 12, 2023 11:56
@git-nandor git-nandor force-pushed the INSTUI-3865_convert_ui-breadcrumb_to_the_new_testing_format branch from 7223dc7 to 12107d7 Compare October 13, 2023 12:41
@balzss balzss merged commit 6043660 into master Oct 13, 2023
4 checks passed
@balzss balzss deleted the INSTUI-3865_convert_ui-breadcrumb_to_the_new_testing_format branch October 13, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants