feat(ui-spinner): add delay prop and functionality to the Spinner #1309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview URL: https://1309--preview-instui.netlify.app |
joyenjoyer
reviewed
Oct 10, 2023
| @@ -61,6 +61,7 @@ class Spinner extends Component<SpinnerProps> { | |||
|
|
|||
| ref: Element | null = null | |||
| private readonly titleId?: string | |||
| private delayTimeout?: NodeJS.Timeout | |||
There was a problem hiding this comment.
Does this work with SSR?
There was a problem hiding this comment.
I see no reason why it shouldn't.
balzss
approved these changes
Oct 11, 2023
matyasf
reviewed
Oct 11, 2023
| describe('<Spinner />', () => { | ||
| describe('with the delay prop', () => { | ||
| it('should delay rendering', async () => { | ||
| const { container } = render(<Spinner delay={1000} />) |
There was a problem hiding this comment.
I'd use a smaller delay (say 300ms) to not slow down our test suite
matyasf
requested changes
Oct 11, 2023
| @@ -148,6 +164,10 @@ class Spinner extends Component<SpinnerProps> { | |||
| </View> | |||
| ) | |||
| } | |||
|
|
|||
| render() { | |||
| return this.state.shouldRender ? this.renderSpinner() : null | |||
There was a problem hiding this comment.
I would still render a transparent rectangle whenshouldRender is false to prevent "pop in" and potential realignment of the UI. Maybe render the svg with visibility: hidden?
There was a problem hiding this comment.
This would defeat the purpose of the delay, since the goal of the feature is to not disrupt the UI if the load time is small
…to the Spinner Closes: INSTUI-3884
matyasf
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: INSTUI-3884